-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ollama models return JSON serializing error #1128
Labels
bug
Something isn't working
Comments
getting same error |
JanusChoi
added a commit
to JanusChoi/jupyter-ai
that referenced
this issue
Nov 30, 2024
dlqqq
pushed a commit
to JanusChoi/jupyter-ai
that referenced
this issue
Dec 4, 2024
dlqqq
pushed a commit
to JanusChoi/jupyter-ai
that referenced
this issue
Dec 5, 2024
dlqqq
added a commit
that referenced
this issue
Dec 5, 2024
* fixing #1128 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * simplify impl and verify dict() requires no args * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: David L. Qiu <david@qiu.dev>
srdas
pushed a commit
to srdas/jupyter-ai
that referenced
this issue
Jan 6, 2025
* fixing jupyterlab#1128 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * simplify impl and verify dict() requires no args * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: David L. Qiu <david@qiu.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Ollama models generate error after returning a valid response:
![image](https://private-user-images.githubusercontent.com/29005/390877026-3bd200c4-470a-4dff-9703-7b0337e09b04.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMzUyNzUsIm5iZiI6MTczOTAzNDk3NSwicGF0aCI6Ii8yOTAwNS8zOTA4NzcwMjYtM2JkMjAwYzQtNDcwYS00ZGZmLTk3MDMtN2IwMzM3ZTA5YjA0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDE3MTYxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAyNWJiZTAzYzhjOWNmMDkzMmM3ZGE1ZDFmMjJkNzIxMDhjYTE0YjgwNjdkY2I2YTIwMzY2ZmZhNjk1NTM5NjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.GoLPBCkgHKu4bj0VwzIRoyHjpE86Xz87FrRtfsTu-4s)
Reproduce
Choose any Ollama model (the error is not specific to a particular Ollama model):
![image](https://private-user-images.githubusercontent.com/29005/390877229-d7b4c518-43d5-4a6b-9d53-ff0102d37560.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMzUyNzUsIm5iZiI6MTczOTAzNDk3NSwicGF0aCI6Ii8yOTAwNS8zOTA4NzcyMjktZDdiNGM1MTgtNDNkNS00YTZiLTlkNTMtZmYwMTAyZDM3NTYwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDE3MTYxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRmMDRiMjM5NzZlMTQ4NDg0OGUyNDEzZWVjYzlkMWJhODE2OTRjZjBiMDM5ZDQzY2NkOTY5ODkxMzA2NDE1OTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.cYoryxZQXTv1BvNEtqDWDwa8Nly1I1AtFzB_sITrJTc)
Then try any prompt. It will return a correct response in one exchange and will follow it up with an unnecessary error as shown above. Error is:
Expected behavior
No JSON serializing error
Environment
Jupyter AI v2.28.2
The text was updated successfully, but these errors were encountered: