Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve development setup #1

Merged
merged 5 commits into from
Feb 21, 2023
Merged

Conversation

dlqqq
Copy link
Member

@dlqqq dlqqq commented Feb 20, 2023

Description

  • Fixes hatch environment setup
  • Adds playground/ directory
  • Corrects and expands on README.md

Testing

  • Fetch and checkout this branch locally
  • Follow instructions in README.md to verify development setup process

Known issues

  • jlpm setup:dev when run as a post install command does not properly link labextensions
    • Partly because setup:dev requires build, which fails because of incompatible @jupyterlab/builder versions, which fails because hatch doesn't seem to respect build dependencies
    • Likely also due to different application directory (jupyter lab path) during installation procedure
  • Pressing Ctrl-C to shut down Jupyter Server in hatch shell causes really weird behavior where Jupyter Server continues to run in background and prints output to terminal
    • Requires further investigation
    • Server can be killed manually by finding its PID with ps u and then doing kill <PID>.
    • This seems to fail freeing up the port though; Jupyter Server bug?

@welcome
Copy link

welcome bot commented Feb 20, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@dlqqq dlqqq force-pushed the improve-dev-process branch from 9a36ef9 to 5161c43 Compare February 20, 2023 22:20
@dlqqq dlqqq merged commit dfbbf1d into jupyterlab:main Feb 21, 2023
@welcome
Copy link

welcome bot commented Feb 21, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@dlqqq dlqqq deleted the improve-dev-process branch February 21, 2023 22:40
@krassowski
Copy link
Member

This seems to fail freeing up the port though; Jupyter Server bug?

I see this often but it did not reproduce reliably for me. I am not sure what is happening but indeed likely not related to work in this repo

dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
* add playground directory

* fix dev setup and correct README

* declare setup:dev task to depend on build task

* Fixed build dependencies in default shell

* Adds user's config file during shell install

---------

Co-authored-by: Piyush Jain <piyushjain@duck.com>
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
* add playground directory

* fix dev setup and correct README

* declare setup:dev task to depend on build task

* Fixed build dependencies in default shell

* Adds user's config file during shell install

---------

Co-authored-by: Piyush Jain <piyushjain@duck.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants