-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update faiss-cpu
version range
#1097
Conversation
Great! But why is |
@krassowski Good callout. The original line of thought was that I agree that we should explore making |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested all steps in the PR.
- Version = faiss-cpi 1.9.0
- /learn works
- /ask works
@srdas Verified locally as well. Thank you for verifying this PR on your machine. @krassowski I've opened a new issue to track making |
@meeseeksdev please backport to v3-dev |
Co-authored-by: david qiu <david@qiu.dev>
Description
This PR updates the version range of
faiss-cpu
to:faiss-cpu~=1.0
, notablyfaiss-cpu==1.9.0
.After this PR is merged and released in a patch version, we can update the dependency in the Conda Forge recipe similarly to close #1096.
Testing instructions
jlpm dev-uninstall && jlpm dev-install
.pip install -U faiss-cpu
.pip show faiss-cpu
, then verify that the latest release v1.9.0 is installed./learn
and/ask
still work in Jupyter AI.