-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds help text for registry model providers in chat UI settings #373
Merged
+114
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We discussed this PR within our team. Currently, we're looking to move away from |
JasonWeill
force-pushed
the
help-text
branch
from
September 7, 2023 17:21
e40373d
to
5a0dc55
Compare
JasonWeill
force-pushed
the
help-text
branch
from
September 7, 2023 21:04
5a0dc55
to
00b5eac
Compare
dlqqq
requested changes
Sep 7, 2023
Closed
dlqqq
approved these changes
Sep 7, 2023
JasonWeill
added a commit
that referenced
this pull request
Sep 7, 2023
* WIP change: display help in settings panel * Interprets markdown, updates Hugging Face help with explicit link * Edits SageMaker help to be neutral in use * Displays help message for all providers with one
JasonWeill
added a commit
to JasonWeill/jupyter-ai
that referenced
this pull request
Sep 7, 2023
…terlab#373) * WIP change: display help in settings panel * Interprets markdown, updates Hugging Face help with explicit link * Edits SageMaker help to be neutral in use * Displays help message for all providers with one
JasonWeill
added a commit
that referenced
this pull request
Sep 7, 2023
#383) * WIP change: display help in settings panel * Interprets markdown, updates Hugging Face help with explicit link * Edits SageMaker help to be neutral in use * Displays help message for all providers with one
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
…terlab#373) * WIP change: display help in settings panel * Interprets markdown, updates Hugging Face help with explicit link * Edits SageMaker help to be neutral in use * Displays help message for all providers with one
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
…terlab#373) * WIP change: display help in settings panel * Interprets markdown, updates Hugging Face help with explicit link * Edits SageMaker help to be neutral in use * Displays help message for all providers with one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #260. If the user selects a model provider that is a registry, with
'*'
listed as its only model, displays the help text in the settings panel, interpreted as markdown. Links are displayed in browser default styles, not as uncolored, undecorated text asa
tags usually are in JupyterLab, and they open in a new window/tab.Minor modification to the Hugging Face help so that its URL always displays as a link. Minor edits to SageMaker endpoints help so that it makes sense both here and in
%ai list
.