/learn skips hidden files/dirs by default, unless "-a" is specified #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3coins
requested changes
Nov 2, 2023
for more information, see https://pre-commit.ci
Co-authored-by: Piyush Jain <piyushjain@duck.com>
Co-authored-by: Piyush Jain <piyushjain@duck.com>
JasonWeill
force-pushed
the
exclude-hidden-dirs
branch
from
3ea112a to
8a1f8c9
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
3coins
approved these changes
Nov 4, 2023
There was a problem hiding this comment.
@JasonWeill
Thanks for adding -a option. Great job on fixing this. 🚀
andrii-i
approved these changes
Nov 4, 2023
|
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter-ai
that referenced
this pull request
Nov 8, 2023
…, unless "-a" is specified
JasonWeill
added a commit
that referenced
this pull request
Nov 8, 2023
…-a" is specified (#451) Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
…upyterlab#427) * Omits hidden files/dirs by default, unless "-a" is specified * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update packages/jupyter-ai/jupyter_ai/document_loaders/directory.py Co-authored-by: Piyush Jain <piyushjain@duck.com> * Update packages/jupyter-ai/jupyter_ai/document_loaders/directory.py Co-authored-by: Piyush Jain <piyushjain@duck.com> * Renames long arg from "all" to "all-files" * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Renames `all` arg in `split` * Updates subdirectory and filename exclusion logic * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Piyush Jain <piyushjain@duck.com>
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
…upyterlab#427) * Omits hidden files/dirs by default, unless "-a" is specified * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update packages/jupyter-ai/jupyter_ai/document_loaders/directory.py Co-authored-by: Piyush Jain <piyushjain@duck.com> * Update packages/jupyter-ai/jupyter_ai/document_loaders/directory.py Co-authored-by: Piyush Jain <piyushjain@duck.com> * Renames long arg from "all" to "all-files" * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Renames `all` arg in `split` * Updates subdirectory and filename exclusion logic * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Piyush Jain <piyushjain@duck.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424.
Omits hidden files and directories by default when calling
/learn, unless-aor--all-filesis specified, in which all supported files under the given directory are parsed.Created a directory
learnmewith a file.secret.txt, reading "The capital of Slobonia is Asterphase".With
/learn -a learnme, the information is learned.