Format image provider #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonWeill
force-pushed
the
format-image-provider
branch
3 times, most recently
from
70b1ce0 to
0987956
Compare
dlqqq
requested changes
Apr 24, 2023
There was a problem hiding this comment.
This looks great! You moved very fast on this, my apologies for not getting the opportunity to review this sooner.
Rather than having HF txt2img models live underneath a separate provider, can you try instead defining the implementation inside of our HfImageProvider class (with provider ID huggingface_hub)? You will want to override the following methods:
validate_environment()- Allow
("text2text-generation", "text-generation", "text-to-image")
- Allow
_call()- Allow the tasks listed above
- Handle output for both txt2txt and txt2img models
You should also be able to leverage super().<method-name>(...) instead of copying the implementation from LangChain. This would be much more robust as it would be more compatible with later releases of LangChain (that may change the implementation).
JasonWeill
force-pushed
the
format-image-provider
branch
from
70dc2aa to
4b69326
Compare
|
@dlqqq The |
JasonWeill
force-pushed
the
format-image-provider
branch
from
e343cfe to
67ece14
Compare
dlqqq
previously requested changes
Apr 25, 2023
dlqqq
requested changes
Apr 28, 2023
* Change raw to text. * Add provider/model metadata to output.
JasonWeill
force-pushed
the
format-image-provider
branch
from
38a95a6 to
3064af1
Compare
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
* Adds image format * WIP: New provider for huggingface_image * Adds image provider to __init__ * Improve magics. * Change raw to text. * Add provider/model metadata to output. * Fixing metadata handling. * Updates user docs * WIP: Prints debug output on initial load * Removes debug info from load * Removes separate provider for images * Outputs image in Base64 format * Removes HF image provider, updates docs * Removes limitation of only supporting JPEG format * Promotes VALID_TASKS out of class * Updates error handling, image generation example notebook * Updates dependencies per @dlqqq --------- Co-authored-by: Brian E. Granger <brgrange@amazon.com> Co-authored-by: Brian E. Granger <ellisonbg@gmail.com>
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* Adds image format * WIP: New provider for huggingface_image * Adds image provider to __init__ * Improve magics. * Change raw to text. * Add provider/model metadata to output. * Fixing metadata handling. * Updates user docs * WIP: Prints debug output on initial load * Removes debug info from load * Removes separate provider for images * Outputs image in Base64 format * Removes HF image provider, updates docs * Removes limitation of only supporting JPEG format * Promotes VALID_TASKS out of class * Updates error handling, image generation example notebook * Updates dependencies per @dlqqq --------- Co-authored-by: Brian E. Granger <brgrange@amazon.com> Co-authored-by: Brian E. Granger <ellisonbg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44.
Adds modified
huggingface_hubprovider that calls HuggingFace models and returns an image as Base64-encoded bytes. Adds an image format type that decodes encoded images.