Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plugin ID format #872

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Fix plugin ID format #872

merged 2 commits into from
Jul 8, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Jul 5, 2024 •
edited
Loading

Fixes #709 and partially #871 (the part about schema not being loaded)

@krassowski krassowski added the bug Something isn't working label Jul 5, 2024
@krassowski krassowski mentioned this pull request Jul 5, 2024
Merged
dlqqq
dlqqq approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dlqqq dlqqq merged commit 27af2c7 into jupyterlab:main Jul 8, 2024
10 checks passed
@krassowski krassowski mentioned this pull request Jul 11, 2024
Closed
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
@krassowski @Marchlak
Fix plugin ID format (jupyterlab#872)
fe31024 
* Fix incorrect plugin ID

* Update plugin ID for inline completions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlqqq dlqqq dlqqq approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin names are not prefixed with the package name
2 participants
@krassowski @dlqqq