Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop command working #11

Merged
merged 29 commits into from
Jun 11, 2024
Merged

Develop command working #11

merged 29 commits into from
Jun 11, 2024

Conversation

cronan03
Copy link
Collaborator

@cronan03 cronan03 commented Jun 8, 2024

Add the develop command and scaffolding of the new command line tool.

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cronan03

First comment, about git usage, I recommend you to use a specific branch in your fork to push changes; see that explanation using forking workflow with feature branch.

The dummy test extension is pushed as part of the changes. That is unwanted. To remove the files from this PR but not from your local copy, you can execute the following command:

git rm --cached -r tests/dummy

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a list of simplification you should be able to do.

We will not extract the commands enable/disable, lock/unlock, list, link/unlink, check, install/uninstall and update commands. So we will focus on develop, build and watch. And we will import also a utilities command line (I'll explain that on our call).

jupyter_builder/base_extension_app.py Outdated Show resolved Hide resolved
jupyter_builder/base_extension_app.py Outdated Show resolved Hide resolved
jupyter_builder/base_extension_app.py Outdated Show resolved Hide resolved
jupyter_builder/base_extension_app.py Outdated Show resolved Hide resolved
jupyter_builder/base_extension_app.py Outdated Show resolved Hide resolved
jupyter_builder/commands.py Outdated Show resolved Hide resolved
jupyter_builder/commands.py Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to remove this file

jupyter_builder/federated_extensions_requirements.py Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file

cronan03 and others added 17 commits June 9, 2024 00:35
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
@fcollonval fcollonval added the enhancement New feature or request label Jun 11, 2024
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cronan03

Let's merge this to move forward.

@fcollonval fcollonval merged commit 727dc28 into jupyterlab:main Jun 11, 2024
15 of 17 checks passed
@fcollonval fcollonval mentioned this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants