Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include jlpm within this package (Issue #15) #20

Merged
merged 19 commits into from
Jul 26, 2024

Conversation

cronan03
Copy link
Collaborator

@cronan03 cronan03 commented Jul 16, 2024

Fixes #15

@fcollonval fcollonval added the enhancement New feature or request label Jul 19, 2024
@fcollonval
Copy link
Member

To fix the linter, you can change the .pre-commit-config.yaml file to exclude yarn.js:

for example

   - repo: https://github.com/codespell-project/codespell
     rev: "v2.2.6"
     hooks:
       - id: codespell
         args: ["-L", "sur,nd"]
+        exclude: jupyter_builder/yarn.js

@fcollonval fcollonval closed this Jul 19, 2024
@fcollonval fcollonval reopened this Jul 19, 2024
.pre-commit-config.yaml Outdated Show resolved Hide resolved
cronan03 and others added 2 commits July 23, 2024 19:00
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
@fcollonval
Copy link
Member

fcollonval commented Jul 23, 2024

Oki I missed that you added the javascript source files within this PR... Could you create another branch for that? This is a good example of why creating multiple branches is a good practice to avoid mixing up various subjects and making it simpler to fix the CI 😉

@fcollonval fcollonval merged commit f8445bd into jupyterlab:main Jul 26, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include jlpm within this package
2 participants