Skip to content

Allow $ to literally denote quantities of USD in chat #361

Allow $ to literally denote quantities of USD in chat

Allow $ to literally denote quantities of USD in chat #361

Triggered via pull request November 7, 2024 07:33
Status Success
Total duration 12m 33s
Artifacts 4

build.yml

on: pull_request
Build jupyter_chat
2m 28s
Build jupyter_chat
Check Links
52s
Check Links
Matrix: build_extensions
Python test on extensions
2m 49s
Python test on extensions
Matrix: integration-tests
Fit to window
Zoom out
Zoom in

Annotations

8 errors, 8 warnings, and 2 notices
tests/chat-file.spec.ts:166:7 › #ychat › should add an id to the chat metadata: python/jupyterlab-collaborative-chat/ui-tests/tests/chat-file.spec.ts#L1
1) tests/chat-file.spec.ts:166:7 › #ychat › should add an id to the chat metadata ──────────────── Test timeout of 60000ms exceeded.
tests/chat-file.spec.ts:166:7 › #ychat › should add an id to the chat metadata: python/jupyterlab-collaborative-chat/ui-tests/http:/localhost:8888/static/lab/jlab_core.30ac71af4fabafb542d8.js?v=30ac71af4fabafb542d8#L1
1) tests/chat-file.spec.ts:166:7 › #ychat › should add an id to the chat metadata ──────────────── Error: proxy.evaluate: Error: Invalid response: 404 Not Found at i.create (http://localhost:8888/static/lab/jlab_core.30ac71af4fabafb542d8.js?v=30ac71af4fabafb542d8:1:1429663) at async m.get (http://localhost:8888/static/lab/jlab_core.30ac71af4fabafb542d8.js?v=30ac71af4fabafb542d8:1:1374452) at async eval (eval at evaluate (:226:30), <anonymous>:2:12) at async <anonymous>:252:30 at i.create (/home/runner/work/jupyter-chat/jupyter-chat/python/jupyterlab-collaborative-chat/ui-tests/http:/localhost:8888/static/lab/jlab_core.30ac71af4fabafb542d8.js?v=30ac71af4fabafb542d8:1:1429663) at async m.get (/home/runner/work/jupyter-chat/jupyter-chat/python/jupyterlab-collaborative-chat/ui-tests/http:/localhost:8888/static/lab/jlab_core.30ac71af4fabafb542d8.js?v=30ac71af4fabafb542d8:1:1374452) at async eval (/home/runner/work/jupyter-chat/jupyter-chat/python/jupyterlab-collaborative-chat/ui-tests/eval at evaluate (:226:30), <anonymous>:2:12) at /home/runner/work/jupyter-chat/jupyter-chat/python/jupyterlab-collaborative-chat/ui-tests/async <anonymous>:252:30 at readFileContent (/home/runner/work/jupyter-chat/jupyter-chat/python/jupyterlab-collaborative-chat/ui-tests/tests/chat-file.spec.ts:32:21) at hasId (/home/runner/work/jupyter-chat/jupyter-chat/python/jupyterlab-collaborative-chat/ui-tests/tests/chat-file.spec.ts:173:27) at Timeout.check (/home/runner/work/jupyter-chat/jupyter-chat/python/jupyterlab-collaborative-chat/ui-tests/node_modules/@jupyterlab/galata/src/utils.ts:183:33)
tests/notifications.spec.ts:108:7 › #notifications › should remove notification when the message is read: python/jupyterlab-collaborative-chat/ui-tests/tests/notifications.spec.ts#L1
2) tests/notifications.spec.ts:108:7 › #notifications › should remove notification when the message is read Test timeout of 60000ms exceeded.
tests/notifications.spec.ts:108:7 › #notifications › should remove notification when the message is read: python/jupyterlab-collaborative-chat/ui-tests/tests/test-utils.ts#L50
2) tests/notifications.spec.ts:108:7 › #notifications › should remove notification when the message is read Error: locator.isChecked: Target page, context or browser has been closed at tests/test-utils.ts:50 48 | const tabName = splitPath[splitPath.length - 1]; 49 | await page.waitForCondition( > 50 | async () => await page.activity.isTabActive(tabName) | ^ 51 | ); 52 | return (await page.activity.getPanelLocator(tabName)) as Locator; 53 | }; at Object.isInSimpleMode (/home/runner/work/jupyter-chat/jupyter-chat/python/jupyterlab-collaborative-chat/ui-tests/node_modules/@jupyterlab/galata/src/utils.ts:311:17) at ActivityHelper.isTabActive (/home/runner/work/jupyter-chat/jupyter-chat/python/jupyterlab-collaborative-chat/ui-tests/node_modules/@jupyterlab/galata/src/helpers/activity.ts:46:21) at /home/runner/work/jupyter-chat/jupyter-chat/python/jupyterlab-collaborative-chat/ui-tests/tests/test-utils.ts:50:37 at Timeout.check (/home/runner/work/jupyter-chat/jupyter-chat/python/jupyterlab-collaborative-chat/ui-tests/node_modules/@jupyterlab/galata/src/utils.ts:183:33)
tests/notifications.spec.ts:108:7 › #notifications › should remove notification when the message is read: python/jupyterlab-collaborative-chat/ui-tests/tests/notifications.spec.ts#L1
2) tests/notifications.spec.ts:108:7 › #notifications › should remove notification when the message is read Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Test timeout of 60000ms exceeded.
tests/notifications.spec.ts:108:7 › #notifications › should remove notification when the message is read: python/jupyterlab-collaborative-chat/ui-tests/tests/notifications.spec.ts#L113
2) tests/notifications.spec.ts:108:7 › #notifications › should remove notification when the message is read Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: locator.scrollIntoViewIfNeeded: Test timeout of 60000ms exceeded. Call log: - waiting for getByRole('main').getByRole('tabpanel', { name: 'my-chat.chat' }).locator('.jp-chat-message').first() 111 | const chatPanel = await openChat(page, FILENAME); 112 | const messages = chatPanel.locator('.jp-chat-message'); > 113 | await messages.first().scrollIntoViewIfNeeded(); | ^ 114 | 115 | await sendMessage(guestPage, FILENAME, MSG_CONTENT); 116 | await page.waitForCondition( at /home/runner/work/jupyter-chat/jupyter-chat/python/jupyterlab-collaborative-chat/ui-tests/tests/notifications.spec.ts:113:28
tests/unread.spec.ts:180:9 › #messagesNavigation › navigation with new unread message › should have unread icon for new messages: python/jupyterlab-collaborative-chat/ui-tests/tests/unread.spec.ts#L1
3) tests/unread.spec.ts:180:9 › #messagesNavigation › navigation with new unread message › should have unread icon for new messages Test timeout of 60000ms exceeded.
tests/unread.spec.ts:180:9 › #messagesNavigation › navigation with new unread message › should have unread icon for new messages: python/jupyterlab-collaborative-chat/ui-tests/tests/test-utils.ts#L50
3) tests/unread.spec.ts:180:9 › #messagesNavigation › navigation with new unread message › should have unread icon for new messages Error: locator.isChecked: Target page, context or browser has been closed at tests/test-utils.ts:50 48 | const tabName = splitPath[splitPath.length - 1]; 49 | await page.waitForCondition( > 50 | async () => await page.activity.isTabActive(tabName) | ^ 51 | ); 52 | return (await page.activity.getPanelLocator(tabName)) as Locator; 53 | }; at Object.isInSimpleMode (/home/runner/work/jupyter-chat/jupyter-chat/python/jupyterlab-collaborative-chat/ui-tests/node_modules/@jupyterlab/galata/src/utils.ts:311:17) at ActivityHelper.isTabActive (/home/runner/work/jupyter-chat/jupyter-chat/python/jupyterlab-collaborative-chat/ui-tests/node_modules/@jupyterlab/galata/src/helpers/activity.ts:46:21) at /home/runner/work/jupyter-chat/jupyter-chat/python/jupyterlab-collaborative-chat/ui-tests/tests/test-utils.ts:50:37 at Timeout.check (/home/runner/work/jupyter-chat/jupyter-chat/python/jupyterlab-collaborative-chat/ui-tests/node_modules/@jupyterlab/galata/src/utils.ts:183:33)
Check Links
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build jupyter_chat
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build collaborative chat extension
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Build ws chat extension
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Python test on extensions
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
ws integration tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/download-artifact@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "jupyterlab_collaborative_chat-artifacts", "jupyterlab_collaborative_chat-playwright-tests", "jupyterlab_ws_chat-artifacts", "jupyterlab_ws_chat-playwright-tests". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
collaborative integration tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/download-artifact@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
🎭 Playwright Run Summary
1 passed (5.1s)
🎭 Playwright Run Summary
3 flaky tests/chat-file.spec.ts:166:7 › #ychat › should add an id to the chat metadata ───────────────── tests/notifications.spec.ts:108:7 › #notifications › should remove notification when the message is read tests/unread.spec.ts:180:9 › #messagesNavigation › navigation with new unread message › should have unread icon for new messages 2 skipped 83 passed (6.0m)

Artifacts

Produced during runtime
Name Size
jupyterlab_collaborative_chat-artifacts
1.7 MB
jupyterlab_collaborative_chat-playwright-tests
1.16 MB
jupyterlab_ws_chat-artifacts
1.34 MB
jupyterlab_ws_chat-playwright-tests
426 KB