Remove websocket chat extension #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brichet
force-pushed
the
remove_ws_chat
branch
from
d439ebc
to
827f1fa
Compare
jtpio
reviewed
Nov 14, 2024
|
|
||
| It is composed of a Python package named `jupyterlab_ws_chat` | ||
| for the server side and a NPM package named `jupyterlab-ws-chat`. | ||
| This extension has been moved to its own [repository](https://github.com/brichet/jupyterlab-ws-chat) |
There was a problem hiding this comment.
I guess it's indeed fine to have it in a separate repo, to demonstrate how to use jupyter-chat 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the websocket chat extension in favour of https://github.com/brichet/jupyterlab-ws-chat.
This update aims to simplify the codebase of the current repo, by keeping only one extension, the one providing chats based on shared documents.
The websocket chat extension was mostly provided here as an other example on
@jupyter/chatusage for an extension.