Fix support for Python 3.9 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dlqqq
commented
Dec 24, 2024
Comment on lines
+43
to
+51
| name: Python unit tests (Python ${{ matrix.python-version }}) | ||
| runs-on: ubuntu-latest | ||
| needs: build_jupyter-chat | ||
| name: Python test on extensions | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - python-version: '3.9' | ||
| - python-version: '3.12' |
There was a problem hiding this comment.
These are the only effective changes to the workflows. All other changes just fix the indentation of this YML file, and were performed automatically by my IDE's linter.
|
The original issue is now caught by a failing job, ensuring that this will not happen again: https://github.com/jupyterlab/jupyter-chat/actions/runs/12486748288/job/34847209610?pr=136 I will now push changes to this branch to fix the issue and mark it as ready for review. Since nobody else is here over the holidays, I'll just merge once CI passes. I've documented everything maintainers need to know in this thread. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
jupyterlab-chat==0.7.0fails in Python 3.9 #134.jupyterlab_chat.