Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ychat #18

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Improve ychat #18

merged 4 commits into from
Apr 22, 2024
+273 −109

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Apr 22, 2024 •
edited
Loading

This PR (1) improve the YChat document:

  • add a users section in the document, to avoid duplicating the whole user information for each message
  • handle remote update of a message (not from the UI)
  • should handle message deletion (not from the UI)

(2) insert message at the correct position in the flow, using the timestamp of the message

@brichet brichet added the enhancement New feature or request label Apr 22, 2024
@brichet brichet merged commit 7cf475b into jupyterlab:main Apr 22, 2024
9 of 10 checks passed
@brichet brichet deleted the improve_ychat branch April 22, 2024 17:44
@brichet brichet mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brichet