Fix message datetime #29
Merged
+90
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the input state to the input itself instead of the chat
…calculate it if the timestamp change
brichet
force-pushed
the
fix_message_datetime
branch
from
04ec859
to
bce7f37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the time displayed in the header of the message.
The message can have a different timestamp computed on server side, but before this PR the representation of this timestamp was cached using the message ID, so it did not change on the chat UI.
This PR caches the string representation using the timestamp instead of message ID.
It also moves the react state
inputin the input widget (instead of the chat widget), to avoid reloading all the messages when the input changes.