Split the project in two packages: UI (npm) and jupyterlab extension #3
Conversation
… a jupyterlab extension
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
|
|
||
| [tool.jupyter-releaser.hooks] | ||
| before-build-npm = [ | ||
| "python -m pip install 'jupyterlab>=4.0.0,<5'", | ||
| "jlpm", | ||
| "YARN_ENABLE_IMMUTABLE_INSTALLS=0 jlpm", |
There was a problem hiding this comment.
Looks like something might still not be behaving as expected.
Normally this env var should not be needed. Maybe we can track that in an issue to have a look later?
There was a problem hiding this comment.
Not sure, because there are 2 packages in the project, and one depends on the other (@jupyter/chat-extension depends on @jupyter/chat), but the bump occurs on both packages.
packages/jupyter-chat-extension/src/__tests__/jupyter_chat_extension.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: martinRenou <martin.renou@gmail.com>
| @@ -0,0 +1,220 @@ | |||
| { | |||
| "name": "@jupyter/chat-extension", | |||
There was a problem hiding this comment.
Should this package be in the @jupyter organization?
There was a problem hiding this comment.
Right, @jupyterlab organization seems more appropriate.
Were you thinking about an other one ?
There was a problem hiding this comment.
maybe it doesn't need organization at all
There was a problem hiding this comment.
OK, we could rename it jupyter-chat-extension, or .jupyterlab-chat-extension
The second choice seems more appropriate, but we should also rename the python package for consistency.
Co-authored-by: Duc Trung Le <leductrungxf@gmail.com>
|
Thanks all for review |
This PR splits the project in 2 packages: