Depend on pydantic directly instead of langchain
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jtpio
commented
Jun 8, 2024
| @@ -30,7 +30,7 @@ dependencies = [ | |||
| "jupyterlab~=4.0", | |||
| "traitlets>=5.0", | |||
| "deepmerge>=1.0", | |||
| "langchain" | |||
| "pydantic>=2" | |||
There was a problem hiding this comment.
Requiring >=2 as per: https://docs.pydantic.dev/latest/migration/#continue-using-pydantic-v1-features
The Pydantic V2 package also continues to provide access to the Pydantic V1 API by importing through pydantic.v1. For example, you can use the BaseModel class from Pydantic V1 instead of the Pydantic V2 pydantic.BaseModel class:
brichet
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
langchainis currently used as a proxy for importingpydantic_v1.So we can probably depend on
pydanticdirectly and update the imports, to avoid having to depend onlangchain.