Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 'Allow $ to literally denote quantities of USD in chat' (#95) #99

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Nov 8, 2024

Porting jupyterlab/jupyter-ai#1094

This PR reverts the changes of #95.

Users can still use $ to delimit inline math, and must double-escape $ symbols to use them literally (\\$). This is aligned with JupyterLab's rendering behavior.

Co-authored-by: david qiu <44106031+dlqqq@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Binder 👈 Launch a Binder on branch brichet/jupyter-chat/revert#95_

@brichet brichet added the bug Something isn't working label Nov 8, 2024
@brichet brichet merged commit a664804 into jupyterlab:main Nov 14, 2024
12 of 13 checks passed
@brichet brichet deleted the revert_#95 branch November 14, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant