Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat panel #155

Closed
wants to merge 9 commits into from
Closed

Chat panel #155

wants to merge 9 commits into from

Conversation

brichet
Copy link
Contributor

@brichet brichet commented May 29, 2023

This PR adds the frontend part of a chat panel.
It has to wait until the backend is ready for use.

image

@welcome
Copy link

welcome bot commented May 29, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/jupyter_collaboration/chat-panel

@brichet brichet force-pushed the chat-panel branch 2 times, most recently from f19da7d to 3433c48 Compare May 29, 2023 08:19
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (94fcd92) 42.77% compared to head (3433c48) 42.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   42.77%   42.77%           
=======================================
  Files           8        8           
  Lines         519      519           
  Branches       73       73           
=======================================
  Hits          222      222           
  Misses        293      293           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fcollonval
Copy link
Member

This looks great @brichet.

I'm wondering if we should not merge the user panel and the chat using an accordion panel to centralize collaboration feature. For example if a user tell the others to jump to his position, in the current layout, the others will need to open the left sidebar to use the feature to jump to a given user position.

This could also be a setting to leave the layout at the user discretion.

@jtpio
Copy link
Member

jtpio commented May 31, 2023

For reference Jupyter AI also has a chat panel: https://jupyter-ai.readthedocs.io/en/latest/users/index.html#the-chat-interface

image

Maybe there could be a way to share some components between the two extensions at some point.

@brichet
Copy link
Contributor Author

brichet commented May 31, 2023

I'm wondering if we should not merge the user panel and the chat using an accordion panel to centralize collaboration feature.

Yes, it can be interesting, also to not overload the page. But it would be interesting to be able to move it to another panel on the fly. Using several collaboration tools at the same time, it can be annoying to switch the accordion every time.

@brichet
Copy link
Contributor Author

brichet commented May 31, 2023

For reference Jupyter AI also has a chat panel: https://jupyter-ai.readthedocs.io/en/latest/users/index.html#the-chat-interface

Thanks for the link, I didn't know about that.
Indeed we should try to share the chat panel component.

@brichet brichet added the enhancement New feature or request label Jan 23, 2024
@Zsailer
Copy link
Member

Zsailer commented Mar 20, 2024

Closing in favor of #237

@Zsailer Zsailer closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants