-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat panel #155
Chat panel #155
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
f19da7d
to
3433c48
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=======================================
Coverage 42.77% 42.77%
=======================================
Files 8 8
Lines 519 519
Branches 73 73
=======================================
Hits 222 222
Misses 293 293
Partials 4 4 ☔ View full report in Codecov by Sentry. |
This looks great @brichet. I'm wondering if we should not merge the user panel and the chat using an accordion panel to centralize collaboration feature. For example if a user tell the others to jump to his position, in the current layout, the others will need to open the left sidebar to use the feature to jump to a given user position.
|
For reference Jupyter AI also has a chat panel: https://jupyter-ai.readthedocs.io/en/latest/users/index.html#the-chat-interface Maybe there could be a way to share some components between the two extensions at some point. |
Yes, it can be interesting, also to not overload the page. But it would be interesting to be able to move it to another panel on the fly. Using several collaboration tools at the same time, it can be annoying to switch the accordion every time. |
Thanks for the link, I didn't know about that. |
cc62232
to
3a4b86e
Compare
Closing in favor of #237 |
This PR adds the frontend part of a chat panel.
It has to wait until the backend is ready for use.