Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the list of opened shared documents to the user awareness #287

Merged
merged 9 commits into from
May 29, 2024

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Apr 17, 2024

Keep track of all opened documents in the collaborators panel.

Related to #284

The file list is an panel under the user in collaboration sidepanel. The appearance of the file list is similar to that of the filebrowser (thanks @martinRenou for the idea).
The document opened in the main area of the collaborator is highlighted with a dot in front (as active document), similar to the running kernel dot in the filebrowser.

Peek 2024-04-19 16-48

Some warnings/questions:

  • it uses the HTML classes (and CSS rules) from the filebrowser. If the filebrowser extension is not loaded, it may not work properly (a remix application for instance). Don't know if we should duplicate the CSS rules.
  • to retrieve the "active" document, we still use the statedb -> layout-restorer -> main, and look for :RTC: in the filename:
    • it works only if the document widget is tracked by the LayoutRestorer
    • it should be updated if :RTC: is removed from the filename

Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/jupyter_collaboration/collab_open_docs

@brichet brichet added the enhancement New feature or request label Apr 17, 2024
@brichet brichet marked this pull request as ready for review April 19, 2024 14:58
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brichet
Copy link
Contributor Author

brichet commented May 29, 2024

@davidbrochart I have a "merging is blocked" warning because I have no approval by reviewers with write access.

May I bypass it or do we want to wait for it ?

Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brichet !

@davidbrochart davidbrochart merged commit 6d90037 into jupyterlab:main May 29, 2024
20 checks passed
@martinRenou martinRenou deleted the collab_open_docs branch May 29, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants