-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix open path error with timeline feature #401
Conversation
a9ef837
to
46ac1ac
Compare
I just rebased on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Meriem-BenIsmail.
I'll need an accompanying test that fails before this PR and succeeds after.
I have a clarification request concerning this PR for fixing the #392 issue. |
I agree that if we "Open from Path" e.g. "Untitled.ipynb", the file should not be opened in collaborative mode, and thus no timeline should be available. But if we "Open from Path" e.g. "RTC:Untitled.ipynb", the file should be opened in collaborative mode, and the timeline should be available. |
46ac1ac
to
7b44441
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Meriem-BenIsmail.
This PR fixes #392