Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open path error with timeline feature #401

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

Meriem-BenIsmail
Copy link
Contributor

This PR fixes #392

Copy link
Contributor

Binder 👈 Launch a Binder on branch Meriem-BenIsmail/jupyter-collaboration/openpath-bug

@davidbrochart
Copy link
Collaborator

davidbrochart commented Nov 18, 2024

I just rebased on main.

@davidbrochart davidbrochart added the bug Something isn't working label Nov 18, 2024
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Meriem-BenIsmail.
I'll need an accompanying test that fails before this PR and succeeds after.

@Meriem-BenIsmail
Copy link
Contributor Author

I have a clarification request concerning this PR for fixing the #392 issue.
If we choose to open a notebook with the 'Open from Path' option, it doesn't open the notebook in collaborative mode (without the RTC prefix) so the timeline slider (also the history icon) shouldn't even be visible if it's not collaborative. That's what I did in this PR so that the history icon wouldn't be shown and the error described in this issue #392 wouldn't occur. I wanted to check if that's the expected behavior that the timeline should have.

@davidbrochart
Copy link
Collaborator

I agree that if we "Open from Path" e.g. "Untitled.ipynb", the file should not be opened in collaborative mode, and thus no timeline should be available. But if we "Open from Path" e.g. "RTC:Untitled.ipynb", the file should be opened in collaborative mode, and the timeline should be available.

Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidbrochart davidbrochart merged commit d328e17 into jupyterlab:main Nov 20, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeline slider is broken when using "Open from path"
2 participants