Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass logger to YStore #63

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Conversation

davidbrochart
Copy link
Collaborator

Needs y-crdt/ypy-websocket#48 to be released.

@davidbrochart davidbrochart marked this pull request as draft November 23, 2022 14:33
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (f5d5d1c) compared to base (0135634).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #63   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          3       3           
  Lines        276     276           
=====================================
  Misses       276     276           
Impacted Files Coverage Δ
jupyter_server_ydoc/handlers.py 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidbrochart davidbrochart added the enhancement New feature or request label Nov 23, 2022
@davidbrochart davidbrochart marked this pull request as ready for review November 23, 2022 20:34
@davidbrochart davidbrochart merged commit 5d5f6dd into jupyterlab:main Nov 23, 2022
@davidbrochart davidbrochart deleted the ystore_log branch November 23, 2022 20:53
hbcarlos pushed a commit to hbcarlos/jupyter-collaboration that referenced this pull request Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant