Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove metadata #64

Merged
merged 3 commits into from
Nov 25, 2022
Merged

Remove metadata #64

merged 3 commits into from
Nov 25, 2022

Conversation

davidbrochart
Copy link
Collaborator

The SQLiteYStore now has a built-in timestamp, and I think we should have it built-in for FileYstore too.
The current metadata was also storing a timestamp, there is no need to store it twice.

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (e6556e1) compared to base (9fe76cc).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #64   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          3       3           
  Lines        276     274    -2     
=====================================
+ Misses       276     274    -2     
Impacted Files Coverage Δ
jupyter_server_ydoc/app.py 0.00% <ø> (ø)
jupyter_server_ydoc/handlers.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidbrochart davidbrochart added the enhancement New feature or request label Nov 25, 2022
@davidbrochart
Copy link
Collaborator Author

In y-crdt/ypy-websocket#57, clearing the document history has been disabled by default. We are setting it back here.

@davidbrochart davidbrochart merged commit 9351186 into jupyterlab:main Nov 25, 2022
@davidbrochart davidbrochart deleted the no_metadata branch November 25, 2022 15:38
hbcarlos pushed a commit to hbcarlos/jupyter-collaboration that referenced this pull request Jan 29, 2023
* Remove metadata

* Set document time-to-live to 24 hours

* Require ypy-websocket>=0.8.0,<0.9.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant