Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to JupyterLab 4 #115

Merged
merged 11 commits into from
Jun 12, 2023
Merged

Switch to JupyterLab 4 #115

merged 11 commits into from
Jun 12, 2023

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented May 31, 2023

Fixes #49

https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/lab-4.0?urlpath=lab

@krassowski I was looking at modernizing this package by merging the opened PRs.

I will left aside the upgrade to 4 to be the focus of this branch. Let me know if I can help.

⚠️ this removes the R kernel.

@welcome
Copy link

welcome bot commented May 31, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@krassowski
Copy link
Member

krassowski commented May 31, 2023

This is odd:

+ jupyter lab workspaces import .binder/workspace.json
[LabWorkspaceImportApp] Workspace could not be exported:
Workspace metadata ID mismatch: expected '/lab' got '/lab'

Seems that the check prepends /:
https://github.com/jupyterlab/jupyterlab_server/blob/4978e2422d8fbb9094af9be84190872f0aed5fea/jupyterlab_server/workspaces_handler.py#L153-L156

@krassowski
Copy link
Member

Giving up on xeus stack:

Could not solve for environment specs
The following packages are incompatible
├─ xeus-cling 0.15.1**  is installable and it requires
│  └─ cppzmq >=4.9.0,<4.10.0a0 , which can be installed;
└─ xleaflet   is uninstallable because there are no viable options
   ├─ xleaflet [0.10.0|0.5.0|...|0.9.0] would require
   │  └─ xeus [>=0.17.0,<0.18.0a0 |>=0.18.1,<0.19.0a0 |>=0.19.1,<0.20.0a0 |>=0.20.0,<0.21.0a0 |>=0.21.1,<0.22.0a0 ], which requires
   │     └─ cppzmq >=4.3.0,<4.4.0a0 , which conflicts with any installable versions previously reported;
   ├─ xleaflet 0.11.0 would require
   │  └─ xeus >=0.23.3,<0.24.0a0  but there are no viable options
   │     ├─ xeus [0.17.0|0.18.1|...|0.23.5], which cannot be installed (as previously explained);
   │     ├─ xeus [0.23.10|0.23.12|...|0.24.1] would require
   │     │  └─ cppzmq >=4.6.0,<4.7.0a0 , which conflicts with any installable versions previously reported;
   │     └─ xeus [0.23.5|0.23.6] would require
   │        └─ cppzmq >=4.4.1,<4.5.0a0 , which conflicts with any installable versions previously reported;
   ├─ xleaflet 0.11.1 would require
   │  └─ xeus >=0.23.14,<0.24.0a0 , which cannot be installed (as previously explained);
   ├─ xleaflet [0.11.1|0.11.2] would require
   │  └─ xeus >=0.24.1,<0.25.0a0  but there are no viable options

etc.

@krassowski
Copy link
Member

So it's working, but:

  • I had to comment out additional xeus-cling packages
  • the workspace restoration does not work (it did not work prior to this PR either)

I kept most packages unpinned for now, but we will probably want to pin them with a working resolution once we are happy with the setup.

@andrii-i
Copy link

andrii-i commented May 31, 2023

"Interactive Widgets" section of demo/notebooks/Cpp.ipynb relies on xeus stack so we might want to temporary remove that part of the demo notebook. Everything else works great (tested demo folder), thank you for working on this @krassowski.

@andrii-i
Copy link

andrii-i commented Jun 1, 2023

Binder is not caching the image (probably due to limited capacity) and has to build it every time with ~75% failure rate for me. Is it the same on your end?

@manics
Copy link

manics commented Jun 1, 2023

I wouldn't rely on binder at the moment, as we're still having problems due to a reduction in capacity and some configuration issues with the other hosts. If it mostly works with mybinder, or at least with repo2docker, that's probably good enough.

@fcollonval
Copy link
Member Author

fcollonval commented Jun 3, 2023

  • the workspace restoration does not work (it did not work prior to this PR either)

I fixed this on master and rebase to fix it here too.

Relax more versions to get a valid resolution

Fix typo

Further resolution fixes

More unpinning and bumping (need recent Python to install Lab 4)

Commend out offline notebook extension

Unpin invoke, comment out C kernel

Formatting for pip

Reinstate x stack

Try without leading slash

xleaflet 0.17 does not exist?

Though it is tagged: https://github.com/jupyter-xeus/xleaflet/releases/tag/0.17.0

Unpin x stack

Comment out all x stack except for xeus-cling

Co-authored-by: krassowski <5832902+krassowski@users.noreply.github.com>
@fcollonval
Copy link
Member Author

6a314c6 works

Now I still need to figure out why the installation of the r-packages crashes.

@fcollonval
Copy link
Member Author

I'm merging as is as it is working and will open a follow-up to fix installing the R kernel

@fcollonval fcollonval merged commit 5adbb27 into master Jun 12, 2023
@fcollonval fcollonval deleted the lab-4.0 branch June 12, 2023 08:09
@andrii-i
Copy link

@fcollonval, @krassowski thank you for working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update enviornment and extensions
4 participants