-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to JupyterLab 4 #115
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
This is odd:
Seems that the check prepends |
Giving up on xeus stack:
etc. |
So it's working, but:
I kept most packages unpinned for now, but we will probably want to pin them with a working resolution once we are happy with the setup. |
"Interactive Widgets" section of demo/notebooks/Cpp.ipynb relies on xeus stack so we might want to temporary remove that part of the demo notebook. Everything else works great (tested |
Binder is not caching the image (probably due to limited capacity) and has to build it every time with ~75% failure rate for me. Is it the same on your end? |
I wouldn't rely on binder at the moment, as we're still having problems due to a reduction in capacity and some configuration issues with the other hosts. If it mostly works with mybinder, or at least with repo2docker, that's probably good enough. |
I fixed this on master and rebase to fix it here too. |
Relax more versions to get a valid resolution Fix typo Further resolution fixes More unpinning and bumping (need recent Python to install Lab 4) Commend out offline notebook extension Unpin invoke, comment out C kernel Formatting for pip Reinstate x stack Try without leading slash xleaflet 0.17 does not exist? Though it is tagged: https://github.com/jupyter-xeus/xleaflet/releases/tag/0.17.0 Unpin x stack Comment out all x stack except for xeus-cling Co-authored-by: krassowski <5832902+krassowski@users.noreply.github.com>
> The env file works locally...
6a314c6 works Now I still need to figure out why the installation of the r-packages crashes. |
This will optimize the cached layer and hopefully solve the postBuild bug
I'm merging as is as it is working and will open a follow-up to fix installing the R kernel |
@fcollonval, @krassowski thank you for working on this |
Fixes #49
https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/lab-4.0?urlpath=lab
@krassowski I was looking at modernizing this package by merging the opened PRs.
I will left aside the upgrade to 4 to be the focus of this branch. Let me know if I can help.