Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use secrets only when publishing release assets #434

Merged
merged 3 commits into from
Mar 28, 2022
Merged

use secrets only when publishing release assets #434

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cd31e0
use secrets only when publishing release assets
mbektas Mar 28, 2022
860167c
set env vars in another step
mbektas Mar 28, 2022
18b934e
fix condition
mbektas Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,17 @@ jobs:
run: |
yarn create_env_installer:${{ matrix.cfg.platform }}

- name: Sets Environment variables for release
run: |
echo "APPLEID=${{ secrets.APPLEID }}" >> $GITHUB_ENV
echo "APPLEIDPASS=${{ secrets.APPLEIDPASS }}" >> $GITHUB_ENV
echo "CSC_KEY_PASSWORD=${{ secrets.CSC_KEY_PASSWORD }}" >> $GITHUB_ENV
echo "CSC_LINK=${{ secrets.CSC_LINK }}" >> $GITHUB_ENV
if: steps.release-exists.outputs.result == 'true'

- name: Create Application Installer
env:
CSC_IDENTITY_AUTO_DISCOVERY: ${{ steps.release-exists.outputs.result }} # disable code signing if not release asset
APPLEID: ${{ secrets.APPLEID }}
APPLEIDPASS: ${{ secrets.APPLEIDPASS }}
CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
CSC_LINK: ${{ secrets.CSC_LINK }}
run: |
yarn dist:${{ matrix.cfg.platform }}

Expand Down