Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to ask user identity on every commit #1251

Merged
merged 9 commits into from
Aug 10, 2023
Merged

Add option to ask user identity on every commit #1251

merged 9 commits into from
Aug 10, 2023

Conversation

eyusupov
Copy link
Contributor

This is useful for situation when multiple people collaborate in the single Jupyter Lab instance so that people can commit PRs under their own name and specify their own emails.

@welcome
Copy link

welcome bot commented Jun 21, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@github-actions
Copy link

Binder 👈 Launch a Binder on branch eyusupov/jupyterlab-git/optional-store-author-info

@eyusupov eyusupov marked this pull request as draft June 21, 2023 13:44
@eyusupov eyusupov force-pushed the optional-store-author-info branch 2 times, most recently from 0cf1791 to 73d056f Compare June 21, 2023 17:19
@eyusupov eyusupov marked this pull request as ready for review June 21, 2023 17:41
fcollonval
fcollonval requested changes Jun 23, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eyusupov this looks great

I have a couple of suggestions.

Would you mind also rebasing your branch to get the CI fixes I pushed in #1252

src/components/GitPanel.tsx Outdated Show resolved Hide resolved
src/components/GitPanel.tsx Show resolved Hide resolved
src/components/GitPanel.tsx Outdated Show resolved Hide resolved
src/components/GitPanel.tsx Outdated Show resolved Hide resolved
src/components/GitPanel.tsx Outdated Show resolved Hide resolved
src/widgets/AuthorBox.ts Outdated Show resolved Hide resolved
src/widgets/AuthorBox.ts Outdated Show resolved Hide resolved
@eyusupov eyusupov force-pushed the optional-store-author-info branch 3 times, most recently from cab9551 to 3210d63 Compare June 23, 2023 18:26
@eyusupov eyusupov requested a review from fcollonval June 23, 2023 18:41
@eyusupov
Copy link
Contributor Author

Integration tests failures seem to be unrelated - I see them failing in another PR too.

fcollonval
fcollonval approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @eyusupov

I pushed a commit to improve slightly the look of the author form.

@fcollonval fcollonval merged commit f35465a into jupyterlab:main Aug 10, 2023
8 checks passed
@welcome
Copy link

welcome bot commented Aug 10, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@eyusupov eyusupov deleted the optional-store-author-info branch August 11, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyusupov @fcollonval