Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable push/pull buttons for empty repos #1365

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Enable push/pull buttons for empty repos #1365

merged 3 commits into from
Oct 25, 2024

Conversation

gjmooney
Copy link
Contributor

This addresses the issue mentioned in #286 (comment) by updating how the Toolbar checks for remotes.

@github-actions GitHub Actions
Copy link

Binder 👈 Launch a Binder on branch gjmooney/jupyterlab-git/enable_push_pull_buttons

@jtpio jtpio added the bug label Oct 24, 2024
@jtpio
Copy link
Member

jtpio commented Oct 24, 2024

Nice, thanks @gjmooney for looking into this!

Looks like there is now a conflict to resolve after the merge of #1364.

jtpio
jtpio approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio
Copy link
Member

jtpio commented Oct 25, 2024

When I tried to reproduce the rest of the #286, it looks like it was working fine, except for these disabled buttons.

So we should be able to close #286 as fixed by this PR 👍

@jtpio jtpio linked an issue Oct 25, 2024 that may be closed by this pull request
Empty AWS CodeCommit repo fails to get upstream branch during push #286
Closed
@jtpio jtpio merged commit da4710f into jupyterlab:main Oct 25, 2024
8 checks passed
@gjmooney gjmooney deleted the enable_push_pull_buttons branch October 25, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeknack86 mikeknack86 mikeknack86 approved these changes

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty AWS CodeCommit repo fails to get upstream branch during push
3 participants
@gjmooney @jtpio @mikeknack86