This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Add a note about the "unverified" warning. #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
reviewed
Feb 5, 2018
README.md
Outdated
| See [advanced.md](docs/advanced.md) for instructions on how to set up your own credentials with Google's servers. | ||
| The application sends a "client ID" to Google's servers to identify itself. | ||
| The default client ID used by the app is set up to work on computers | ||
| running JupyterLab using `http://localhost` on ports`8888` through `8899`. |
There was a problem hiding this comment.
missing a space after "ports"
|
After the fix @blink1073 recommended, LGTM. |
ian-r-rose
force-pushed
the
add_unverified_note
branch
from
8224d59 to
0838fc8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @damianavila