-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add files for JupyterLite #45
Conversation
Current state: the extension fails to load with the following error:
This is likely because the extension expects |
I think that switching to lazy imports ( |
Of note, JupyterLab 3.6 4.0 will also break with the current version because:
|
I do note there is a delay in the launcher card appearing (especially noticeable on RTD): perhaps the command/shell-level stuff can be out in the plugin, with a |
Also noticed this on Binder while checking #47 |
Now looking good on RTD: jupyterlite-playground.mp4 |
Should be good to go for a first version. Planning to make a new release of |
@@ -14,4 +14,4 @@ build_cmd = "build:prod" | |||
npm = ["jlpm"] | |||
|
|||
[tool.check-manifest] | |||
ignore = ["jupyterlab_plugin_playground/labextension/**", "yarn.lock", ".*", "package-lock.json", "scripts/**"] | |||
ignore = ["docs/**", "jupyterlab_plugin_playground/labextension/**", "yarn.lock", ".*", "package-lock.json", "scripts/**"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe break up into lines and sort
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also add link to docs in the setup.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hoping to do more cleanups in #51
cc @krassowski @bollwyvl if you want to have another look since most of the points raised above have been addressed. Planning to do more follow-up cleanups in #51 |
docs/index.md
Outdated
@@ -0,0 +1,8 @@ | |||
Try `jupyterlab-plugin-playground` in your browser right now [![try-badge]][try] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm... not clickable in rtd... also maybe throw a {hint}
around it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried a couple of things to get the link to work, not sure whether it's because the file is generated.
Maybe rediraffe? There's also some extra paths in conf.py... the lite
conf.py sets a couple.
…On Thu, Nov 24, 2022, 07:53 Jeremy Tuloup ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/index.md
<#45 (comment)>
:
> @@ -0,0 +1,8 @@
+Try `jupyterlab-plugin-playground` in your browser right now [![try-badge]][try]
I tried a couple of things to get the link to work, not sure whether it's
because the file is generated.
—
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCRHR2I4SRZ7Y5YBAAJTWJ5XMLANCNFSM55WLQBLQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Planning to get this one so it can be used in JupyterLite already by clicking on the badge in the README, and we can address the link issue mentioned above separately. |
Fixes #16
Start setting up ReadTheDocs so it can be used to easily demo the JupyterLab Plugin Playground with JupyterLite.