Make file browser respond to focussed elements #13577

gabalafou · 2022-12-12T16:51:56Z

References

Accessibility Issues Needing Addressing for WCAG 2.1 compliance (As of Version 2.2.6) #9399
Make focus visible (mostly CSS) #13415 - The main impetus for this PR

PR #13415 made focus visible, which as @krassowski pointed out:

This surfaces an issue with the file browser ignoring focused elements.

In order to understand this PR, it's important to understand that "selection" and "focus" are not the same thing. The easiest way to understand the difference between the two is to play with the file browser in Windows or Ubuntu. If you have Windows or Ubuntu, and you open the file browser, you can move focus independent of selection by pressing ctrl + arrow key. Focus is visually indicated with a focus ring, while selection is indicated with a highlight, or background color. This PR basically adopts the focus-versus-selection patterns in Windows and Ubuntu for the JupyterLab file browser.

Code changes

Most of the code changes in this PR are to the DirListing class in the @jupyterlab/filebrowser package. The main change is the addition of a new private state variable _focusIndex, which keeps track of where the focus should be in the directory listing.

Previously, every file or directory in the file browser had a tab index of 0. I changed it so that there should only ever be one file item node at a time that can be focussed with the tab key. This makes navigating the JupyterLab UI easier because the user won't have to tab through all of the items in the file browser to get to another part of the UI.

I use the focus index in a few places to simplify DirListing methods. For example, the multi select method used to iterate through the directory listing to find the selected item nearest to the one clicked, but now it simply looks up the item at the focus index.

There are a number of other code changes to fix issues I uncovered with the file browser keyboard shortcuts. For example, I moved the Backspace keyboard shortcut out of the JSON schema file and into the DirListing class because it wasn't working when the DirListing was empty, and I couldn't think of a better way to fix it.

Test coverage

I added tests for about half of the code changes I made. Before adding more tests, I wanted to get this PR up for review, since changes requested in review could change the test code.

User-facing changes

Up/down arrow key, not tab key, moves focus.
- Moving keyboard focus from one file to another in the file browser is now exclusively done via the up and down arrow keys. Previously the user could move focus (but not selection) with the tab key (but it was useless because the file browser previously only responded to keyboard shortcuts on selected items, completely ignoring which item had focus; now it's not so easy to unintentionally move focus independently of selection).
CTRL+Space now selects/unselects files.
Backspace now works to go up even when folder is empty.
User can now do a keyboard-only discontiguous multi-select.
- Previously, the only way to select discontinuous groups of files in the file browser was by shift-clicking with the mouse (or by enabling checkboxes in the settings editor and then clicking the checkboxes next to files). There was no way to do this with just the keyboard.
- This is accomplished the same way that Ubuntu and Windows do it: CTRL+ up (or down) arrow key moves the focus. Then CTRL+Space toggles selection.
Hopefully users will barely notice this, but the way multi-select is done is now different. For multi-select, I found inconsistencies between Mac, Windows, and Ubuntu, so I combined some characteristics that I found helpful in those platforms with some of my own choices. We will need people to try it out and see if it feels intuitive or not.
When user renames a file, focus stays on that file after rename (or if the user presses the esc key).
Enter keyboard shortcut can now open multiple files instead of just one.
Commands that cannot operate on multiple files (such as "copy download link") do not appear in the context menu when user has selected multiple files.
Focus stays in directory listing after deleting files.

Backwards-incompatible changes

None, as far as I'm aware.

jupyterlab-probot · 2022-12-12T16:51:59Z

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

gabalafou

Done self-reviewing!

gabalafou · 2022-12-12T16:57:06Z

packages/filebrowser-extension/src/index.ts

@@ -346,6 +346,11 @@ const downloadPlugin: JupyterFrontEndPlugin<void> = {
            Clipboard.copyToSystem(url);
          });
      },
+      isVisible: () =>


The "copy download link" command does not accept multiple files, so do not show it in the (right-click) context menu when multiple files are selected.

gabalafou · 2022-12-12T16:57:44Z

packages/filebrowser-extension/src/index.ts

@@ -1111,6 +1110,11 @@ function addCommands(
        return widget.rename();
      }
    },
+    isVisible: () =>


There is no batch, multi-file "rename" command, so do not show it in the (right-click) context menu when multiple files are selected.

gabalafou · 2022-12-12T16:59:19Z

packages/filebrowser-extension/src/index.ts

@@ -1130,8 +1134,10 @@ function addCommands(
      Clipboard.copyToSystem(item.value.path);
    },
    isVisible: () =>
+      // So long as this command only handles one file at time, don't show it


The "copy path" command does not support multiple files, so do not show it in the (right-click) context menu when multiple files are selected.

Note: in Windows, when multiple files are selected, the copy-path command puts each path on a newline in the clipboard.

gabalafou · 2022-12-12T18:32:50Z

packages/filebrowser/src/browser.ts

+   * Create a new directory
+   */
+  createNewDirectory(): Promise<Contents.IModel> {
+    return this._createNew(this._futureNewDirectory, {


This re-write allows consuming code to know when the operation is done.

Note that my implementation of "done" means the new directory or file has both been created and renamed by the user.

Rewriting it this way both allowed me to better test these methods as well as remove the TODO comment inside the methods.

gabalafou · 2022-12-12T18:37:00Z

packages/filebrowser/src/browser.ts

+   *
+   * Go up one level in the directory tree.
+   */
+  async goUp() {


this.listing is a protected member so I can't do browserForPath.listing.goUp() in the execute function of the "filebrower:go-up" command, I need to expose the method this way and call browserForPath.goUp()

gabalafou · 2022-12-13T00:31:05Z

packages/filebrowser/src/listing.ts

-      // text node was specifically chosen to receive shortcuts because
-      // text element gets substituted with input area during file name edits
-      // which conveniently deactivate irrelevant shortcuts.
-      text.tabIndex = 0;


This is now handled in onUpdateRequest. All item nodes except for the currently focussed one are given tabIndex = -1.

gabalafou · 2022-12-13T00:36:31Z

packages/filebrowser/src/listing.ts

-          case 38: // Up arrow
-            event.stopPropagation();
-            event.preventDefault();
-            if (edit.selectionStart !== edit.selectionEnd) {
-              edit.selectionStart = edit.selectionEnd = 0;
-            }
-            break;
-          case 40: // Down arrow
-            event.stopPropagation();
-            event.preventDefault();
-            if (edit.selectionStart !== edit.selectionEnd) {
-              edit.selectionStart = edit.selectionEnd = edit.value.length;
-            }


I'm not sure why these up/down arrow handlers on edit were ever needed. This is the default behavior of an input field in Chrome.

I have a suspicion that this code was needed at some point, but then something was refactored that made this code no longer necessary.

This is also the default behavior on Firefox (using Debian OS). Could you test it on Safary?

Yep. Tested on Safari. Works the same.

gabalafou · 2022-12-13T00:38:02Z

packages/filebrowser/style/base.css

@@ -113,11 +113,6 @@
  outline: 0;
 }

-.jp-DirListing:focus-visible {


This PR removes the tabIndex = 0 on this element, so these styles are no longer needed.

gabalafou · 2022-12-13T00:39:42Z

packages/filebrowser/style/base.css

@@ -273,6 +268,12 @@
  user-select: none;
 }

+/* https://css-tricks.com/copy-the-browsers-native-focus-styles/ */
+.jp-DirListing-itemText:focus {


Some people might not like it, but I want the focus ring to be always visible, whether the user selects a file via mouse or via keyboard.

Part of the reason why is that I think it can help the user make sense of the multi-select, which uses the currently focussed item as one of the endpoints of the multi-select.

gabalafou · 2022-12-13T00:45:13Z

packages/filebrowser/src/listing.ts

+        labelWrapper.classList.add('jp-mod-visible');
+      } else {
+        // Disable tabbing to all other checkboxes.
+        checkbox.tabIndex = -1;


It's unnecessary to allow the user to tab to the checkbox next to a file because the state of the checkbox is controlled by the state of the class.

fcollonval

Thank @gabalafou

Here is a first quick review - I did not test it yet.

fcollonval · 2022-12-14T10:41:27Z

packages/filebrowser/src/listing.ts

-          case 38: // Up arrow
-            event.stopPropagation();
-            event.preventDefault();
-            if (edit.selectionStart !== edit.selectionEnd) {
-              edit.selectionStart = edit.selectionEnd = 0;
-            }
-            break;
-          case 40: // Down arrow
-            event.stopPropagation();
-            event.preventDefault();
-            if (edit.selectionStart !== edit.selectionEnd) {
-              edit.selectionStart = edit.selectionEnd = edit.value.length;
-            }


This is also the default behavior on Firefox (using Debian OS). Could you test it on Safary?

fcollonval · 2022-12-14T10:42:03Z

packages/filebrowser/style/base.css

@@ -273,6 +268,12 @@
  user-select: none;
 }

+/* https://css-tricks.com/copy-the-browsers-native-focus-styles/ */
+.jp-DirListing-itemText:focus {


fcollonval · 2022-12-14T10:45:28Z

packages/filebrowser/style/base.css

@@ -273,6 +268,12 @@
  user-select: none;
 }

+/* https://css-tricks.com/copy-the-browsers-native-focus-styles/ */
+.jp-DirListing-itemText:focus {
+  outline: 5px auto Highlight;


I would rather choose a CSS theme property than Highlight (from the system-color) because the background of the highlight will not use the system-color and therefore can lake contrast.

Ok will do.

fcollonval · 2022-12-14T10:46:23Z

packages/filebrowser/style/base.css

+/* https://css-tricks.com/copy-the-browsers-native-focus-styles/ */
+.jp-DirListing-itemText:focus {
+  outline: 5px auto Highlight;
+  outline: 5px auto -webkit-focus-ring-color;


I guess this is the same about that specific webkit property.

fcollonval · 2022-12-14T10:48:54Z

packages/filebrowser/test/listing.spec.ts

+// Copyright (c) Jupyter Development Team. Distributed under the terms of the
+// Modified BSD License.


Let's not touch the license header

Suggested change

// Copyright (c) Jupyter Development Team. Distributed under the terms of the

// Modified BSD License.

// Copyright (c) Jupyter Development Team.

// Distributed under the terms of the Modified BSD License.

Oh good catch. That was my editor. Should be fixed now.

fcollonval · 2022-12-14T11:07:44Z

packages/filebrowser/src/browser.ts

-  createNewDirectory(): void {
-    if (this._directoryPending === true) {
-      return;
+  private _createNew(


This is a weird pattern. I would suggest you use a pattern like that:

private async _createNew(options): Promise<Contents.IModel> { // ... } async createNewDirectory(): Promise<Contents.IModel> { if(this._directoryPending) { return this._directoryPending; } this._directoryPending = this._createNew(...); const model = await this._directoryPending; // Reset directory pending this._directoryPending = null; return model; } private _directoryPending: Promise<Contents.IModel> | null = null;

A general comment, I would advice to use async/await/try..catch pattern rather than then/catch to ease code reading and modernize it.

Hehe. Agreed. I thought there was some reason for doing it the way I did but now I can't remember why, so I'll implement it the way you suggest.

fcollonval · 2022-12-15T13:41:54Z

packages/filebrowser-extension/schema/browser.json

+      "command": "filebrowser:toggle-main",
+      "keys": ["Accel Shift F"],
+      "selector": "body"


Is the Backspace shortcut a WCAG recommendation? Is it something users may want to customize?

That shortcuts is defined in packages/filebrowser-extension/schema/widget.json. So it should be needed here.

Suggested change

"command": "filebrowser:toggle-main",

"keys": ["Accel Shift F"],

"selector": "body"

There was a merge conflict here. I must not have resolved it correctly. The only diff should be removing the Backspace shortcut from this JSON file. I'll fix this.

fcollonval · 2022-12-15T13:47:06Z

packages/filebrowser/src/listing.ts

+        const promise = renameFile(manager, oldPath, newPath);
+        return promise.then(
+          () => newName,
+          error => {


Your reasoning makes sense.

Would you mind switching to async/await syntax to ease code readability?

gabalafou

Thanks for your review comments @fcollonval! I believe I addressed all of them. If I missed anything, it wasn't intentional, please bring it to my attention again.

I changed the CSS rule that controls the focus ring of the directory items to use theme variables and checked it in light-mode across a variety of browsers (Chrome, Safari, and Firefox on MacOS). I also checked dark-mode on MacOS Chrome. I probably need @isabela-pf or someone more familiar than me with the graphic design conventions of JupyterLab to give that a look and okay it before we merge this in.

gabalafou · 2022-12-22T14:44:25Z

packages/filebrowser-extension/schema/browser.json

+      "command": "filebrowser:toggle-main",
+      "keys": ["Accel Shift F"],
+      "selector": "body"


There was a merge conflict here. I must not have resolved it correctly. The only diff should be removing the Backspace shortcut from this JSON file. I'll fix this.

gabalafou · 2022-12-22T14:54:26Z

packages/filebrowser/src/listing.ts

+        const promise = renameFile(manager, oldPath, newPath);
+        return promise.then(
+          () => newName,
+          error => {


Sure. Happy to rewrite using async/await. The only reason I didn't do it to begin with is that this file does not have a lot of unit tests so I've tried to change it as little as possible—just enough to achieve what I need, for fear of accidentally breaking something.

But I will gladly convert this and some of the other code that this PR touches to use async-await syntax.

gabalafou · 2023-01-10T22:49:26Z

packages/filebrowser/src/listing.ts

-          case 38: // Up arrow
-            event.stopPropagation();
-            event.preventDefault();
-            if (edit.selectionStart !== edit.selectionEnd) {
-              edit.selectionStart = edit.selectionEnd = 0;
-            }
-            break;
-          case 40: // Down arrow
-            event.stopPropagation();
-            event.preventDefault();
-            if (edit.selectionStart !== edit.selectionEnd) {
-              edit.selectionStart = edit.selectionEnd = edit.value.length;
-            }


Yep. Tested on Safari. Works the same.

gabalafou · 2023-01-10T22:53:33Z

packages/filebrowser/src/browser.ts

-  createNewDirectory(): void {
-    if (this._directoryPending === true) {
-      return;
+  private _createNew(


Hehe. Agreed. I thought there was some reason for doing it the way I did but now I can't remember why, so I'll implement it the way you suggest.

gabalafou · 2023-01-10T22:53:55Z

packages/filebrowser/style/base.css

@@ -273,6 +268,12 @@
  user-select: none;
 }

+/* https://css-tricks.com/copy-the-browsers-native-focus-styles/ */
+.jp-DirListing-itemText:focus {
+  outline: 5px auto Highlight;


Ok will do.

gabalafou · 2023-01-10T22:54:01Z

packages/filebrowser/style/base.css

+/* https://css-tricks.com/copy-the-browsers-native-focus-styles/ */
+.jp-DirListing-itemText:focus {
+  outline: 5px auto Highlight;
+  outline: 5px auto -webkit-focus-ring-color;


gabalafou · 2023-01-10T22:54:42Z

packages/filebrowser/test/listing.spec.ts

+// Copyright (c) Jupyter Development Team. Distributed under the terms of the
+// Modified BSD License.


Oh good catch. That was my editor. Should be fixed now.

gabalafou · 2023-03-07T16:49:13Z

Thanks @fcollonval! I pushed two commits that should hopefully fix the test timeout and linter error.

My biggest concern before merging this PR is me moving Backspace out of the settings-editable shortcuts and into the DirListing class. Could you comment on that specifically @fcollonval? Or perhaps @krassowski? since I believe @krassowski added the Backspace keyboard shortcut in #6859.

gabalafou · 2023-03-08T13:42:23Z

I don't think the UI and Visual Regression Tests are related but I'm not quite sure how to check...

fcollonval · 2023-03-08T13:49:26Z

My biggest concern before merging this PR is me moving Backspace out of the settings-editable shortcuts and into the DirListing class. Could you comment on that specifically @fcollonval? Or perhaps @krassowski? since I believe @krassowski added the Backspace keyboard shortcut in #6859.

I don't have strong feeling about this. It seems that Backspace is the shortcut used by OS file browser. So I guess it is fine to get it hard coded. But let's wait for Mike feedback.

Regarding UI tests, they are currently broken on master.

gabalafou · 2023-03-08T14:25:25Z

@fcollonval I opened an issue to keep track of the bug you mentioned in your review and I will try to submit a fix in the near future:

Focus in filebrowser lost when closing context menu #14153

krassowski · 2023-03-09T07:52:12Z

I do not have strong feelings on hard-coding Backspace for "go-up" but it would be nice if we preserved this as dropping a shortcut will break user settings when upgrading and limit customisability (and we talked about accessibility overlapping with customisability on the call yesterday). I see this comment:

You can reason from the way it's configured here that it doesn't work if the directory is empty, because if it's empty there is no .jp-DirListing-itemText node.

I believe we can just adjust the selector for the keybinding and it would just work. Is there any other reason for hard-coding it?

gabalafou · 2023-03-09T13:23:57Z

I believe we can just adjust the selector for the keybinding and it would just work. Is there any other reason for hard-coding it?

No other reason. I just don't know how to do it. 😑

gabalafou · 2023-03-09T13:24:39Z

But I can give it another think and get back to you.

isabela-pf · 2023-03-09T19:10:45Z

I'm not finding any problems! I think this PR is well-scoped and I think everything happening with focus in the file browser makes sense to me. Just to note some positives:

I'm happy to find the styling matches upcoming WCAG 2.2's more specific focus appearance guidelines.
I'm also happy to find the CSS changes seem mindful of the existing variables.
It works in light and dark modes!

I am curious about the ways that the focus styling are different in the file browser versus other areas of the UI, but I do think that is outside the scope of the PR. Just noting it for follow up on my part.

A final note from me: CTRL+ up (or down) arrow key did not allow me to move focus separate from selection, but instead triggered something on my operating system that I'm not familiar with. If this isn't a problem for other Mac users, I won't push it on this PR because I know I'm likely not using the most recent MacOS.

gabalafou · 2023-03-09T19:19:00Z

Thanks @isabela-pf! I want to follow up on your note about ctrl + up/down. Can you describe what it triggered on your OS? Does it happen only in the browser or does it happen in any app?

I would say that the keyboard-only, discontiguous multi-select feature is more aimed at Windows and Ubuntu users than Mac users, but all the same, I would like things to mostly work the same across operating systems, including older versions of Mac OS.

gabalafou · 2023-03-09T19:30:29Z

Also, to your note about focus styling, I would add that in my experience, JupyterLab's focus styling is not terribly consistent, and that this is an area that could use some polishing, but yes, I agree that it's a bigger scope than this PR.

I wonder if a good first step towards consistency would be to add some variables for outline styles that could be reused across the app. I have the variables.css file in mind. (That one links to the light theme version, but there is also a dark theme version of the file.) I imagine adding a section like:

/* Outline (focus ring) */
--jp-outline-color: white;
--jp-outline-style: solid;
--jp-outline-width: 1px;

And for the dark theme version:

/* Outline (focus ring) */
--jp-outline-color: #111;
--jp-outline-style: solid;
--jp-outline-width: 1px;

I'm not sure about those values, but... something like that to start.

This reverts commit bdf0525.

gabalafou

@krassowski, I'm happy to report that I was able to keep the backspace as a user-configurable shortcut.

I think this PR is ready for merge now. 😄

gabalafou · 2023-03-17T21:53:28Z

packages/filebrowser-extension/schema/browser.json

+    {
+      "command": "filebrowser:go-up",
+      "keys": ["Backspace"],
+      "selector": ".jp-DirListing:focus"
+    },


Okay, this seems to do the trick: just add another selector to handle the case when the directory is empty and leave the other selector alone. I wish I could leave a comment in this JSON file.

This :focus selector works for when the directory is empty because the only node (within the directory listing widget) that can receive focus at that point is the directory listing node itself. We cannot use the selector without :focus though because then it would get triggered if the user were in the middle of renaming a file, makes a typo, and then presses backspace to delete the typo.

I tested this change three ways:

Opening an empty folder then pressing backspace

Opening a non-empty folder then pressing backspace

Renaming a file and pressing backspace while editing the file name

fcollonval

Thanks the patience @gabalafou

Waiting for a second run of js-filebrowser to be sure

fcollonval

Thanks @gabalafou

github-actions bot assigned gabalafou Dec 12, 2022

github-actions bot added Design System CSS pkg:filebrowser tag:CSS For general CSS related issues and pecadilloes labels Dec 12, 2022

gabalafou mentioned this pull request Dec 12, 2022

File browser has numerous keyboard issues, some newly surfaced Quansight-Labs/jupyter-a11y-mgmt#182

Closed

gabalafou force-pushed the filebrowser-keyboard-focus branch from 149cd9f to 6e7d068 Compare December 12, 2022 23:50

Make file browser respond to focussed elements

1879719

gabalafou force-pushed the filebrowser-keyboard-focus branch from 6e7d068 to 1879719 Compare December 13, 2022 00:07

Do not prevent space-click on check-all checkbox

56bb994

gabalafou commented Dec 13, 2022

View reviewed changes

fcollonval added the enhancement label Dec 13, 2022

void goUp() to make the linter happy and avoid run-time errors

89275eb

fcollonval requested changes Dec 15, 2022

View reviewed changes

trallard mentioned this pull request Dec 16, 2022

Fix tab traps in JupyterLab Quansight-Labs/jupyter-a11y-mgmt#134

Open

gabalafou mentioned this pull request Dec 22, 2022

Team update - Dec 21, 2022 Quansight-Labs/jupyter-a11y-mgmt#186

Closed

gabalafou and others added 11 commits December 23, 2022 11:49

Merge branch 'master' into filebrowser-keyboard-focus

1ba8ead

undo unintended change to browser.json

798a761

rewrite directory/file pending code

b9fac45

rewrite doRename using async/await syntax

942dcf3

use theme rather than system colors for focus ring on file

62ade7f

unify keyboard + mouse multiSelect

1f79c74

doRename -> userInputForRename

976cf25

Automatic application of license header

1e10b87

fix tests

e14210e

Add comments and rewrite special case in multi select

b79602f

fix license headers

81b30d7

gabalafou commented Jan 10, 2023

View reviewed changes

gabalafou added 2 commits January 10, 2023 17:59

remove Backspace keyboard shortcut from JSON file (now handled by class)

3486214

only handle arrow press on item to avoid confusing UX

8f8a562

Merge branch 'master' into filebrowser-keyboard-focus

70266d5

fcollonval added this to the 4.0.0 milestone Mar 8, 2023

gabalafou mentioned this pull request Mar 8, 2023

Focus in filebrowser lost when closing context menu #14153

Open

gabalafou mentioned this pull request Mar 9, 2023

Team update - Mar 08, 2023 Quansight-Labs/jupyter-a11y-mgmt#201

Closed

gabalafou mentioned this pull request Mar 16, 2023

Team update - Mar 15, 2023 Quansight-Labs/jupyter-a11y-mgmt#203

Closed

gabalafou added 3 commits March 17, 2023 18:29

Revert "Revert "restore backspace (not sure why it was removed)""

c762fe1

This reverts commit bdf0525.

restore Backspace as user-configurable shortcut

f7dffae

adjust selector

4e7f36b

gabalafou commented Mar 17, 2023

View reviewed changes

fcollonval previously approved these changes Mar 30, 2023

View reviewed changes

fcollonval added 2 commits April 7, 2023 11:26

Merge branch 'master' into pr/gabalafou/13577

91408e2

Fix Jest unit tests

7a2f007

fcollonval approved these changes Apr 7, 2023

View reviewed changes

fcollonval merged commit a946155 into jupyterlab:master Apr 7, 2023

gabalafou mentioned this pull request Apr 13, 2023

Team update - Apr 12, 2023 Quansight-Labs/jupyter-a11y-mgmt#207

Closed

ibdafna mentioned this pull request Jun 13, 2023

File browser items in focus state draw a rectangle around the itemText node, which disappears when hovering on any menu #14678

Closed

brichet mentioned this pull request Dec 6, 2023

Accessibility Issues Needing Addressing for WCAG 2.1 compliance (As of Version 2.2.6) #9399

Open

24 tasks

gabalafou mentioned this pull request Feb 19, 2024

File browser checkboxes not keyboard accessible #15819

Open

2 tasks

github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024

		// Copyright (c) Jupyter Development Team. Distributed under the terms of the
		// Modified BSD License.

	"command": "filebrowser:toggle-main",
	"keys": ["Accel Shift F"],
	"selector": "body"

Make file browser respond to focussed elements #13577

Make file browser respond to focussed elements #13577

Conversation

gabalafou commented Dec 12, 2022 • edited Loading

References

Code changes

Test coverage

User-facing changes

Backwards-incompatible changes

jupyterlab-probot bot commented Dec 12, 2022

gabalafou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fcollonval left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gabalafou left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gabalafou commented Mar 7, 2023 • edited Loading

gabalafou commented Mar 8, 2023

fcollonval commented Mar 8, 2023

gabalafou commented Mar 8, 2023

krassowski commented Mar 9, 2023

gabalafou commented Mar 9, 2023

gabalafou commented Mar 9, 2023

isabela-pf commented Mar 9, 2023

gabalafou commented Mar 9, 2023

gabalafou commented Mar 9, 2023

gabalafou left a comment

Choose a reason for hiding this comment

gabalafou Mar 17, 2023 • edited Loading

Choose a reason for hiding this comment

fcollonval left a comment

Choose a reason for hiding this comment

fcollonval left a comment

Choose a reason for hiding this comment

gabalafou commented Dec 12, 2022 •

edited

Loading

gabalafou commented Mar 7, 2023 •

edited

Loading

gabalafou Mar 17, 2023 •

edited

Loading