Fix opening of console #3471
Fix opening of console #3471
Conversation
|
I have verified that the this does fix the issue. But I see something else (also in master) that may be related. If you load JupyterLab with session state and a running Console, the title in the Console stays missing for quite a long while (about 10 seconds after lab restores):
As a clue, only the last created one suffers from this issue:
|
|
Hmm, I'm not seeing that behavior anymore, that's what this line was for: |
|
Hmmm, let me rebuild and make sure... |
|
Actually, looking at that again we need a fallback title for when we don't have the session name, updated to use |
|
Why would this only fail for the most recent console?
…On Fri, Dec 22, 2017 at 11:02 PM, Steven Silvester ***@***.*** > wrote:
Actually, looking at that again we need a fallback title for when we don't
have the session name, updated to use Console until it is available.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3471 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABr0CUoshovuvYISEcroBQ3kOt1429Rks5tDKWKgaJpZM4RLkjx>
.
--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
bgranger@calpoly.edu and ellisonbg@gmail.com
|
|
Because we don't have a |
|
The fallback title does work now. But I am still confused. When I have 3 consoles open and I refresh the page, Console 1 and Console 2 get title almost immediately, but Console 3 takes 10 seconds between getting Console and Console 3. Is this the expected behavior? |
|
No, it's not clear to me why that would be happening. |
|
Can you reproduce that behavior? |
|
I can reproduce the issue on a page refresh, investigating. |
|
Fixed the title issue. |
lock
bot
added
the
status:resolved-locked
Fixes #3465.