Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blocked/allowed extension naming in JupyterLab #8799

Merged

Conversation

echarles
Copy link
Member

@echarles echarles commented Aug 8, 2020

References

Fixes #8533

To be merged with jupyterlab/jupyterlab_server#111

Code changes

User-facing changes

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@echarles echarles changed the title Use blocked/allowed extension naming in the docs Use blocked/allowed extension naming in JupyterLab Aug 8, 2020
@echarles echarles marked this pull request as ready for review August 8, 2020 13:26
@blink1073
Copy link
Contributor

Thanks for doing this @echarles! I'm afk today but will review/merge tomorrow.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073 blink1073 added this to the 3.0 milestone Aug 9, 2020
@blink1073 blink1073 merged commit 67b270c into jupyterlab:master Aug 9, 2020
@echarles
Copy link
Member Author

echarles commented Aug 9, 2020

Thx @blink1073 for review, fix and merge.

@blink1073 blink1073 added the api-change A change that should be accompanied by a major version increase label Aug 11, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-change A change that should be accompanied by a major version increase documentation pkg:apputils pkg:extensionmanager status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace usage of insensitive terms
2 participants