Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CodeMirror text color issue with dark Jupyter theme. #8919

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Fix CodeMirror text color issue with dark Jupyter theme. #8919

merged 1 commit into from
Aug 27, 2020

Conversation

AlbertHilb
Copy link
Contributor

Fixes #8792.

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@github-actions github-actions bot added tag:Design System CSS If a PR is editing any CSS files please add this tag for design team to review. pkg:codemirror tag:CSS For general CSS related issues and pecadilloes labels Aug 27, 2020
blink1073
blink1073 approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The usage failure is unrelated, tracked in #8918

@blink1073 blink1073 added this to the 3.0 milestone Aug 27, 2020
@blink1073 blink1073 merged commit c6c2198 into jupyterlab:master Aug 27, 2020
@AlbertHilb AlbertHilb deleted the ColorFix branch August 28, 2020 14:12
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
pkg:codemirror status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes tag:Design System CSS If a PR is editing any CSS files please add this tag for design team to review.
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Punctuation invisible in dark mode on jlab 3
2 participants
@AlbertHilb @blink1073