Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @types/webpack (shipped with webpack 5) #9167

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 15, 2020

References

Follow-up to #9148

(#9148 (comment))

Code changes

From the release notes: https://webpack.js.org/blog/2020-10-10-webpack-5-release/#typescript-typings

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jtpio jtpio added this to the 3.0 milestone Oct 15, 2020
@jasongrout jasongrout merged commit 90b58a8 into jupyterlab:master Oct 17, 2020
@jtpio jtpio deleted the webpack-5-types branch October 17, 2020 07:05
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Apr 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants