Add link for prebuilt extensions too #9702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
@meeseeksdev please backport to 3.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jan 29, 2021
|
Is there an extra step that extension developers need to take in order for this to work? I tried a few pre-built extensions on binder but they did not get the URL displayed. Sorry I'm late to the party. |
blink1073
added a commit
that referenced
this pull request
Jan 29, 2021
…2-on-3.0.x Backport PR #9702 on branch 3.0.x (Add link for prebuilt extensions too)
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes
Replaces check for extension type with check for the actual necessary data.
Existing code sets
urlto''if there is none, and since''is falsy in JS, this works out.User-facing changes
Prebuilt extension titles will link to the extension’s URL target