Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jupyterlab4 with lab4_port commits #38

Conversation

willh-cmyk
Copy link
Contributor

I've taken my changes from here, which pass the various github action checks.
And cherry-picked the relevant un-merged changes from here.

Copy link

Binder 👈 Launch a Binder on branch WilliamHoltam/jupyterlab_pygments/upgrade-to-jupyterlab4-add-lab4_port-commits

@willh-cmyk willh-cmyk marked this pull request as draft November 13, 2023 10:23
@willh-cmyk willh-cmyk marked this pull request as ready for review November 13, 2023 10:43
@willh-cmyk
Copy link
Contributor Author

@krassowski ready for review & added PR label :)

@jtpio jtpio added the enhancement New feature or request label Nov 13, 2023
@benz0li
Copy link

benz0li commented Nov 13, 2023

Does it also build with Python 3.12?

package-lock.json Outdated Show resolved Hide resolved
@willh-cmyk
Copy link
Contributor Author

Does it also build with Python 3.12?

It does now :)

@benz0li
Copy link

benz0li commented Nov 18, 2023

Should this PR be rebooted using the extension upgrade script? https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#upgrading-extension-using-the-upgrade-script

This would help pick up the latest changes to the extension template.

#31 (comment)

@jtpio Does this meet the expectations? Are you responsible for reviewing and merging?

@krassowski
Copy link
Member

Can you update jupyterlab/python/node versions in binder/environment.yml to make testing easier?

@willh-cmyk
Copy link
Contributor Author

Can you update jupyterlab/python/node versions in binder/environment.yml to make testing easier?

Which versions do you need, the latest of each?

@willh-cmyk
Copy link
Contributor Author

Please add comments if there are any further changes I can make to make things easier for you :)

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @WilliamHoltam (and @RRosio) this looks good to me. I will wait with merging until Monday so that @jtpio has a chance to take a look.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good, thanks!

@willh-cmyk
Copy link
Contributor Author

@krassowski I think we're good to go

@benz0li
Copy link

benz0li commented Nov 22, 2023

@krassowski It would be great to have this released by the end of the week.

Thanks to everyone involved!

@krassowski krassowski merged commit a26fdd6 into jupyterlab:main Nov 22, 2023
5 checks passed
Copy link

welcome bot commented Nov 22, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@benz0li
Copy link

benz0li commented Nov 23, 2023

@martinRenou Thank you for releasing v0.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants