-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to jupyterlab4 with lab4_port commits #38
Upgrade to jupyterlab4 with lab4_port commits #38
Conversation
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
@krassowski ready for review & added PR label :) |
Does it also build with Python 3.12? |
- install latest rimraf
It does now :) |
@jtpio Does this meet the expectations? Are you responsible for reviewing and merging? |
Can you update jupyterlab/python/node versions in |
Which versions do you need, the latest of each? |
Please add comments if there are any further changes I can make to make things easier for you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff looks good, thanks!
@krassowski I think we're good to go |
@krassowski It would be great to have this released by the end of the week. Thanks to everyone involved! |
@martinRenou Thank you for releasing v0.3.0. |
I've taken my changes from here, which pass the various github action checks.
And cherry-picked the relevant un-merged changes from here.