Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt ruff and address lint #343

Merged
merged 7 commits into from
Dec 8, 2022
Merged

Conversation

blink1073
Copy link
Contributor

@bollwyvl
Copy link
Contributor

bollwyvl commented Dec 8, 2022

Just as I see you pushing, but apropos of nothing:

Typing :: Typed

is now a trove classifier. Maybe we start using around the house?

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

Base: 80.90% // Head: 80.89% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (bf39f55) compared to base (7138c26).
Patch coverage: 76.13% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
- Coverage   80.90%   80.89%   -0.02%     
==========================================
  Files          22       22              
  Lines        1697     1701       +4     
  Branches      323      323              
==========================================
+ Hits         1373     1376       +3     
- Misses        224      225       +1     
  Partials      100      100              
Impacted Files Coverage Δ
jupyterlab_server/settings_utils.py 78.50% <41.66%> (ø)
jupyterlab_server/process.py 67.51% <44.44%> (ø)
jupyterlab_server/app.py 83.33% <50.00%> (ø)
jupyterlab_server/settings_handler.py 78.04% <50.00%> (ø)
jupyterlab_server/handlers.py 78.78% <75.00%> (-0.49%) ⬇️
jupyterlab_server/workspaces_handler.py 88.80% <75.00%> (ø)
jupyterlab_server/workspaces_app.py 88.05% <80.00%> (ø)
jupyterlab_server/test_utils.py 67.07% <87.50%> (-0.40%) ⬇️
jupyterlab_server/_version.py 77.77% <100.00%> (+2.77%) ⬆️
jupyterlab_server/config.py 73.96% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 enabled auto-merge (squash) December 8, 2022 12:40
@blink1073
Copy link
Contributor Author

Maybe we start using around the house?

Done!

@blink1073 blink1073 merged commit 60570d7 into jupyterlab:main Dec 8, 2022
@blink1073 blink1073 deleted the add-ruff branch December 8, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants