Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change language environment variable #366

Merged
merged 13 commits into from
Jan 15, 2023

Conversation

fcollonval
Copy link
Member

This inverts the logic to by default use the default OS locale to set JupyterLab language (if the associated language pack is installed).

It uses the class API of Python gettext instead of the global API as recommended by the Python documentation.

@fcollonval fcollonval force-pushed the fix/read-lang-from-env-var branch from 5e59c4f to 98ae9ed Compare January 5, 2023 19:39
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2023

Codecov Report

Base: 81.05% // Head: 82.14% // Increases project coverage by +1.09% 🎉

Coverage data is based on head (6aeffd1) compared to base (94823fe).
Patch coverage: 83.87% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   81.05%   82.14%   +1.09%     
==========================================
  Files          22       22              
  Lines        1752     1742      -10     
  Branches      334      330       -4     
==========================================
+ Hits         1420     1431      +11     
+ Misses        231      213      -18     
+ Partials      101       98       -3     
Impacted Files Coverage Δ
jupyterlab_server/settings_utils.py 78.70% <40.00%> (+0.19%) ⬆️
jupyterlab_server/translations_handler.py 82.14% <80.00%> (-5.86%) ⬇️
jupyterlab_server/translation_utils.py 89.95% <89.36%> (+8.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit a226eaa into jupyterlab:main Jan 15, 2023
@blink1073
Copy link
Contributor

I'll make a minor release tomorrow.

@fcollonval fcollonval deleted the fix/read-lang-from-env-var branch January 16, 2023 13:43
@fcollonval
Copy link
Member Author

Thanks for fixing the CI and the release @blink1073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants