-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't change language environment variable #366
Don't change language environment variable #366
Conversation
5e59c4f
to
98ae9ed
Compare
for more information, see https://pre-commit.ci
Codecov ReportBase: 81.05% // Head: 82.14% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 81.05% 82.14% +1.09%
==========================================
Files 22 22
Lines 1752 1742 -10
Branches 334 330 -4
==========================================
+ Hits 1420 1431 +11
+ Misses 231 213 -18
+ Partials 101 98 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'll make a minor release tomorrow. |
Thanks for fixing the CI and the release @blink1073 |
This inverts the logic to by default use the default OS locale to set JupyterLab language (if the associated language pack is installed).
It uses the class API of Python
gettext
instead of the global API as recommended by the Python documentation.