Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more linting #369

Merged
merged 2 commits into from
Jan 28, 2023
Merged

Add more linting #369

merged 2 commits into from
Jan 28, 2023

Conversation

blink1073
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2023

Codecov Report

Base: 81.90% // Head: 81.18% // Decreases project coverage by -0.72% ⚠️

Coverage data is based on head (c40c92d) compared to base (07908d3).
Patch coverage: 32.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
- Coverage   81.90%   81.18%   -0.72%     
==========================================
  Files          22       22              
  Lines        1752     1765      +13     
  Branches      333      333              
==========================================
- Hits         1435     1433       -2     
- Misses        216      229      +13     
- Partials      101      103       +2     
Impacted Files Coverage Δ
jupyterlab_server/config.py 73.52% <0.00%> (-0.44%) ⬇️
jupyterlab_server/process.py 65.43% <0.00%> (-2.09%) ⬇️
jupyterlab_server/test_utils.py 69.40% <0.00%> (-3.12%) ⬇️
jupyterlab_server/workspaces_app.py 85.71% <0.00%> (-2.53%) ⬇️
jupyterlab_server/licenses_handler.py 97.63% <33.33%> (-0.78%) ⬇️
jupyterlab_server/workspaces_handler.py 88.18% <50.00%> (-0.62%) ⬇️
jupyterlab_server/translation_utils.py 89.91% <78.94%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 enabled auto-merge (squash) January 28, 2023 22:10
@blink1073 blink1073 merged commit fb77c74 into jupyterlab:main Jan 28, 2023
@blink1073 blink1073 deleted the adopt-more-lint branch January 28, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants