Skip to content

Commit

Permalink
Update doc and fix installing chromium
Browse files Browse the repository at this point in the history
  • Loading branch information
fcollonval committed May 20, 2024
1 parent dded51c commit 7ba2cfa
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 6 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
browser: [chrome, firefox, webkit]
# exclude:
# # Playwright webkit binary is not compatible with ubuntu
# - os: ubuntu-latest
# browser: webkit
browser: [chromium, firefox, webkit]
exclude:
# Playwright webkit binary is not compatible with ubuntu
- os: ubuntu-latest
browser: webkit
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
Expand Down
15 changes: 14 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ yarn build:src

## Tests

The tests are written using karma to simulate a browser environment.
The tests are written using [web-test-runner](https://modern-web.dev/docs/test-runner/overview/)
to test in browser environment (provided by [playwright](https://playwright.dev/)).

To run the tests, run:

Expand All @@ -27,6 +28,18 @@ yarn build:test
yarn test # optionally test:chrome, test:firefox, or test:webkit
```

You can run the tests manually to debug them by going inside one package (e.g. `packages/application`)
and then executing `yarn test:debug`. This should open your browser
in which you will be able to select the test file to execute.
The outcome of the tests are displayed in the web browser console and you
can use the web browser debug capability to debug the tests.

> [!NOTE]
> The test files are transpiled and bundled before execution. Therefore
> when debugging in the browser, you must use the file `tests/lib/bundle.test.js`.
> Then you will need to apply the fix to the Typescript test file and re-run
> the test command (to trigger the bundling) to check the test is fixed.
## Examples

Lumino examples are in the `examples/` folder. To build and run an example:
Expand Down

0 comments on commit 7ba2cfa

Please sign in to comment.