Merge branch 'allow-mapping-to-mod-keys' of ssh://ssh.github.com:443/…

…g547315/lumino into allow-mapping-to-mod-keys
jupyterlab · Oct 20, 2023 · ab4c7bf · ab4c7bf
2 parents d9a3f6f + 3ebd720
commit ab4c7bf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/check-api-changes.yml b/.github/workflows/check-api-changes.yml
@@ -52,7 +52,7 @@ jobs:
 
       - name: Get API changes
         id: api-changed
-        uses: tj-actions/changed-files@v39.2.1
+        uses: tj-actions/changed-files@v39.2.2
         with:
           base_sha: 'HEAD~1'
           sha: 'HEAD'

diff --git a/packages/commands/tests/src/index.spec.ts b/packages/commands/tests/src/index.spec.ts
@@ -1335,11 +1335,11 @@ describe('@lumino/commands', () => {
         expect(keystroke).to.equal('');
       });
 
-      it('should return nothing for keys that are marked as modifier in keyboard layout', () => {
+      it('should return keys that are marked as modifier in keyboard layout', () => {
         let keystroke = CommandRegistry.keystrokeForKeydownEvent(
           new KeyboardEvent('keydown', { keyCode: 17, ctrlKey: true })
         );
-        expect(keystroke).to.equal('');
+        expect(keystroke).to.equal('Ctrl ');
       });
     });
   });