Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated "p-*" Phosphor-based selectors #106

Closed
nmichaud opened this issue Aug 17, 2020 · 3 comments
Closed

Drop deprecated "p-*" Phosphor-based selectors #106

nmichaud opened this issue Aug 17, 2020 · 3 comments
Milestone

Comments

@nmichaud
Copy link
Contributor

nmichaud commented Aug 17, 2020

I've noticed that dragging tabs in the TabBar widget feels much laggier than before. I narrowed the culprit down to the merge that migrated the CSS selectors to new 'lm-*' based prefixes (#20) while keeping the original ones. Chrome seems to have some issues when an element has two different selectors with identical stylesheets. Is there a timeline to remove the deprecated selectors from the codebase? I assume JupyterLab has fully migrated over by now.

@nmichaud nmichaud changed the title Dropping deprecated "p-*" phosphor-based selectors Timeline for dropping deprecated "p-*" phosphor-based selectors? Aug 17, 2020
@jasongrout
Copy link
Contributor

An update: JLab 3 still has the phosphor compatibility shim, and the hope is to remove it in JLab 4 (planned release at the end of this year) to fully migrate to Lumino with no backwards compatibility for Phosphor.

Chrome seems to have some issues when an element has two different selectors with identical stylesheets.

Interesting. I haven't noticed a lag. Do you have a reference link or Chrome bug report for problem?

@nmichaud
Copy link
Contributor Author

Chrome seems to have some issues when an element has two different selectors with identical stylesheets.

Interesting. I haven't noticed a lag. Do you have a reference link or Chrome bug report for problem?

Sorry that was a red herring. Turns out it was this issue - #128. Removing all the phosphor based selectors ended up fixing the problem but hid what the underlying problem was.

@jasongrout
Copy link
Contributor

Thanks for following up.

@jasongrout jasongrout reopened this Feb 12, 2021
@fcollonval fcollonval mentioned this issue Sep 16, 2021
16 tasks
@afshin afshin added this to the Lumino 2 milestone Jul 26, 2022
@afshin afshin closed this as completed Aug 5, 2022
@afshin afshin changed the title Timeline for dropping deprecated "p-*" phosphor-based selectors? Drop deprecated "p-*" phosphor-based selectors? Aug 8, 2022
@afshin afshin moved this to Done in Lumino 2 Aug 8, 2022
@afshin afshin added this to Lumino 2 Aug 8, 2022
@afshin afshin changed the title Drop deprecated "p-*" phosphor-based selectors? Drop deprecated "p-*" phosphor-based selectors Aug 8, 2022
@afshin afshin changed the title Drop deprecated "p-*" phosphor-based selectors Drop deprecated "p-*" Phosphor-based selectors Aug 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: done
Development

No branches or pull requests

3 participants