-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop deprecated "p-*" Phosphor-based selectors #106
Comments
An update: JLab 3 still has the phosphor compatibility shim, and the hope is to remove it in JLab 4 (planned release at the end of this year) to fully migrate to Lumino with no backwards compatibility for Phosphor.
Interesting. I haven't noticed a lag. Do you have a reference link or Chrome bug report for problem? |
Sorry that was a red herring. Turns out it was this issue - #128. Removing all the phosphor based selectors ended up fixing the problem but hid what the underlying problem was. |
Thanks for following up. |
I've noticed that dragging tabs in the TabBar widget feels much laggier than before. I narrowed the culprit down to the merge that migrated the CSS selectors to new 'lm-*' based prefixes (#20) while keeping the original ones. Chrome seems to have some issues when an element has two different selectors with identical stylesheets. Is there a timeline to remove the deprecated selectors from the codebase? I assume JupyterLab has fully migrated over by now.
The text was updated successfully, but these errors were encountered: