[PATCH] MediaStreamErrorEvent removed from TypeScript from 4.4 onward

[SnarkBoojum]

I'm trying to package lumino v2021.8.23 into Debian, and the compilation of virtualdom fails with the above error message.

[welcome]

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.

You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[SnarkBoojum]

Relevant link discussing making some things obsolete -- including MediaStreamEventError: microsoft/TypeScript-DOM-lib-generator#1029

Relevant link to a project with a similar problem: basst314/ngx-webcam#130

[SnarkBoojum]

It looks like a trivial:

--- lumino.orig/packages/virtualdom/src/index.ts
+++ lumino/packages/virtualdom/src/index.ts
@@ -569,7 +569,7 @@
   ondrop: DragEvent;
   ondurationchange: Event;
   onemptied: Event;
-  onended: MediaStreamErrorEvent;
+  onended: ErrorEvent;
   onerror: ErrorEvent;
   onfocus: FocusEvent;
   oninput: Event;
--- lumino.orig/review/api/virtualdom.api.md
+++ lumino/review/api/virtualdom.api.md
@@ -52,7 +52,7 @@
     ondrop: DragEvent;
     ondurationchange: Event;
     onemptied: Event;
-    onended: MediaStreamErrorEvent;
+    onended: ErrorEvent;
     onerror: ErrorEvent;
     onfocus: FocusEvent;
     oninput: Event;

would be enough to get rid of this issue.

[blink1073]

Thanks @SnarkBoojum! I think this should help with jupyterlab/jupyterlab#10993 as well. Mind submitting a PR?

[SnarkBoojum]

I have no clue how one does a PR, and for a two-line change, that looks overkill...