Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated MediaStreamErrorEvent #237

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Remove deprecated MediaStreamErrorEvent #237

merged 1 commit into from
Sep 22, 2021

Conversation

afshin
Copy link
Member

@afshin afshin commented Sep 22, 2021

Fixes #236
h/t @SnarkBoojum

@jupyterlab-probot
Copy link

Thanks for making a pull request to lumino!
To try out this branch on binder, follow this link: Binder

blink1073
blink1073 approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 added the bug Something isn't working label Sep 22, 2021
@blink1073 blink1073 merged commit 6377a3e into jupyterlab:master Sep 22, 2021
@blink1073
Copy link
Contributor

blink1073 commented Sep 22, 2021 •
edited
Loading

Publishing a version of @lumino/widgets 1.19.x with this fix so we can use it in JupyterLab 3.1

@blink1073
Copy link
Contributor 

 - @lumino/application => 1.16.1
 - @lumino/commands => 1.12.1
 - @lumino/datagrid => 0.20.1
 - @lumino/default-theme => 0.10.1
 - @lumino/virtualdom => 1.8.1
 - @lumino/widgets => 1.19.1

@blink1073 blink1073 mentioned this pull request Sep 22, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PATCH] MediaStreamErrorEvent removed from TypeScript from 4.4 onward
2 participants
@afshin @blink1073