Drop deprecated 'p-*' selectors #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I think the big decision that wasn't clear from #9 is: is this a change requiring a major version Lumino? If so, I think this shouldn't be the only change in Lumino 2, so what is the larger story about what Lumino 2 is going to be? |
|
This requires a major version bump, I think. I don't think we must have other API breakages here. This could simply be a transitional version. I think releasing a version of Lumino that has no deprecated APIs is enough of a win, personally. |
|
How would this affect ipywidgets 7? |
afshin
reviewed
Aug 17, 2020
afshin
reviewed
Aug 17, 2020
|
Closing this PR because it is implemented in this commit (authored by @afshin and @nmichaud) in #319 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes #9.
This will require careful review.