Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for DockPanel.tabsMovable to set false to all tabs #109

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

nmichaud
Copy link
Contributor

each() will abort on first false, so setting tabsMovable=false on a DockPanel with multiple tabs will only set the first one false.

each() will abort on first false, so setting tabsMovable=false on
a DockPanel with multiple tabs will only set the first one false.
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 6844908 into jupyterlab:master Aug 20, 2020
@nmichaud nmichaud deleted the fix/dockpanel-tabsmovable branch April 30, 2021 17:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants