Make focus consistent with active element in menus #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 14, 2021 13:31
marthacryan
force-pushed
the
remove-tabindex
branch
from
9302ea6
to
d77c5e8
Compare
|
Kicking CI |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the menu bar / menu widgets, these changes make the "active element" consistent with focus, both by putting the "active element" in focus and by setting the "active element" to the current focused element (i.e. if user uses tab to navigate the menu).
This could use more thorough testing, I've been trying to find any edge cases that cause bugs with this but any extra testing would be appreciated!