Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accordion panel #205

Merged
merged 7 commits into from
Jul 29, 2021
Merged

Add accordion panel #205

merged 7 commits into from
Jul 29, 2021

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Jul 22, 2021 •
edited
Loading

This PR adds an accordion panel (including an example).

Features:

  • Build on top of SplitPanel - multiple region of the accordion panel can be opened simulatenously and resized at will
  • Keyboard navigation:
    • Tab to loop on sections and content of opened sections
    • Space and Enter opens/closes the section
    • Up / Down (for vertical) or Left / Right (for horizontal) Arrow to loop on section titles
    • Home / End to jump to first or last titles

Tasks:

  • Keyboard navigation
  • Handle all widgets collapsed
  • Handle horizontal layout
  • Handle alignment
  • Check that SplitPanel is still working as expected
  • Test
  • Documentation

accordion_panel

@fcollonval fcollonval added the enhancement New feature or request label Jul 22, 2021
@trungleduc trungleduc mentioned this pull request Jul 26, 2021
Merged
@fcollonval fcollonval marked this pull request as ready for review July 26, 2021 16:13
@afshin afshin mentioned this pull request Jul 28, 2021
Closed
blink1073
blink1073 approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! I'm planning to make a new release on Tuesday 3 Apr.

@blink1073 blink1073 merged commit d54b9eb into jupyterlab:master Jul 29, 2021
@fcollonval fcollonval deleted the ft/accordion-panel branch August 2, 2021 11:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcollonval @blink1073