-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update devDependencies
, fix eslint
, use ES6
#330
Conversation
eslint
eslint
, update lerna
…ests more robust in Windows/Firefox
eslint
, update lerna
devDependencies
, fix eslint
, use `ES6
devDependencies
, fix eslint
, use `ES6devDependencies
, fix eslint
, use ES6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @afshin
I got a few suggestions.
"husky": "^4.2.5", | ||
"lerna": "^4.0.0", | ||
"lerna": "^5.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 we should definitely bring that to JLab
"webpack": "^5.74.0", | ||
"webpack-cli": "^4.10.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is probably out of scope for this PR. But it will be nice to drop webpack because it is inconsistent to distribute lumino using rollup but testing it using webpack.
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
devDependencies
, fix eslint
, use ES6
devDependencies
, fix eslint
, use ES6
This PR:
lerna
eslint
errors and warningsrollup
webpack
With this PR
Before this PR
cf. #325