Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor retro(), clean up iterators #361

Merged
merged 3 commits into from
Aug 22, 2022
Merged

Refactor retro(), clean up iterators #361

merged 3 commits into from
Aug 22, 2022

Conversation

afshin
Copy link
Member

@afshin afshin commented Aug 20, 2022

Follow on to #346

@afshin afshin added bug Something isn't working maintenance Dependencies, build, technical debt, etc. labels Aug 20, 2022
@afshin afshin added this to the Lumino 2 milestone Aug 20, 2022
@afshin afshin self-assigned this Aug 20, 2022
@afshin afshin closed this Aug 20, 2022
@afshin afshin reopened this Aug 20, 2022
@afshin afshin force-pushed the native-iterators branch 3 times, most recently from d3e17fb to c8491cb Compare August 20, 2022 08:46
@afshin
Copy link
Member Author

afshin commented Aug 20, 2022 •
edited
Loading

The RTD failure seems to be unrelated:

UnavailableInvalidChannel: The channel is not accessible or is invalid.
  channel name: pkgs/main
  channel url: https://repo.anaconda.com/pkgs/main
  error code: 404```

@afshin afshin force-pushed the native-iterators branch 5 times, most recently from aba434c to 4a96ee3 Compare August 21, 2022 18:11
blink1073
blink1073 approved these changes Aug 21, 2022
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! No idea what is going on with RTD.

@blink1073
Copy link
Contributor

Same thing is happening in jupyterlab_server: https://readthedocs.org/projects/jupyterlab-server/builds/17855741/

@blink1073
Copy link
Contributor

Sigh. readthedocs/readthedocs.org#9527

@afshin afshin changed the title Fix logic bug in retro(), clean up iterators Refactor retro(), clean up iterators Aug 22, 2022
fcollonval
fcollonval approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcollonval fcollonval merged commit 06ca95d into jupyterlab:main Aug 22, 2022
vidartf
vidartf reviewed Aug 23, 2022
View reviewed changes
packages/algorithm/src/retro.ts
const it = (object as IRetroable<T>).retro();
let item: IteratorResult<T>;
while (!(item = it.next()).done) {
yield item.value;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, you could have also used yield* https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/yield*

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vidartf vidartf vidartf left review comments

@fcollonval fcollonval fcollonval approved these changes

@blink1073 blink1073 blink1073 approved these changes

Assignees

@afshin afshin

Labels
bug Something isn't working maintenance Dependencies, build, technical debt, etc.
Projects
None yet
Milestone
Lumino 2
Development

Successfully merging this pull request may close these issues.
4 participants
@afshin @blink1073 @vidartf @fcollonval