Fix service type #382
Fix service type #382
Conversation
afshin
force-pushed
the
fix-service-type
branch
from
9935d8d
to
98d33bd
Compare
afshin
force-pushed
the
fix-service-type
branch
4 times, most recently
from
25038fc
to
bb9224e
Compare
.github/workflows/license-header.yml
Outdated
| with: | ||
| files: | | ||
| packages/**/*.css | ||
| packages/**/*.js | ||
| packages/**/*.ts | ||
| packages/**/*.tsx | ||
|
|
||
| - name: Did things change? | ||
| if: steps.changed-files.outputs.any_changed == 'true' | ||
| shell: bash -l {0} | ||
| run: | | ||
| echo "Yes! Some things changed!" | ||
| echo | git status --short --branch |
There was a problem hiding this comment.
@afshin did you encounter an unexpected file being committed or is this just a fail-safe?
Note: to be sure to display the changes detected by the previous action, I would recommend using the following snippet:
lumino/.github/workflows/check-api-changes.yml
Lines 64 to 67 in d6a592c
There was a problem hiding this comment.
No new files are committed, but for some reason the next job (the one that does the git push) fails, presumably because there is nothing to push? I'm not 100% sure what is happening. I reverted my modifications to the CI job because I was just experimenting.
There was a problem hiding this comment.
I got some similar problems with the API changes workflow. So I applied the same trick in dc2692d; i.e. forcing the commit then use the diff between HEAD and HEAD~1 to see if something changed.
afshin
force-pushed
the
fix-service-type
branch
from
bb9224e
to
fd1e34a
Compare
|
For those of us trying to follow along: What exactly does this change do? What problems did the old code cause, and how is this a fix? |
|
Oh, I see now that this is a cleanup after #377. |
Right, this puts the signatures back to what they originally were. |
cleanup after #377
Fix API signatures